tomopy/tomopy

View on GitHub
source/tomopy/recon/wrappers.py

Summary

Maintainability
D
2 days
Test Coverage

File wrappers.py has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

# #########################################################################
# Copyright (c) 2015-2019, UChicago Argonne, LLC. All rights reserved.    #
Severity: Minor
Found in source/tomopy/recon/wrappers.py - About 4 hrs to fix

    Function astra_rec has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    def astra_rec(tomo, center, recon, theta, vol_geom, niter, proj_type, gpu_index, opts):
        # Lazy import ASTRA
        import astra as astra_mod
        nslices, nang, ndet = tomo.shape
        cfg = astra_mod.astra_dict(opts['method'])
    Severity: Minor
    Found in source/tomopy/recon/wrappers.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ufo_dfi has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def ufo_dfi(tomo, center, recon, theta, **kwargs):
        """
        Reconstruct object using UFO's Direct Fourier pipeline
        """
        import gi
    Severity: Minor
    Found in source/tomopy/recon/wrappers.py - About 1 hr to fix

      Function astra has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def astra(tomo, center, recon, theta, **kwargs):
          """
          Reconstruct object using the ASTRA toolbox
      
          Extra options
      Severity: Minor
      Found in source/tomopy/recon/wrappers.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ufo_fbp has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def ufo_fbp(tomo, center, recon, theta, **kwargs):
          """
          Reconstruct object using UFO's FBP pipeline
          """
          import gi
      Severity: Minor
      Found in source/tomopy/recon/wrappers.py - About 1 hr to fix

        Function astra_rec has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def astra_rec(tomo, center, recon, theta, vol_geom, niter, proj_type, gpu_index, opts):
        Severity: Major
        Found in source/tomopy/recon/wrappers.py - About 1 hr to fix

          Function lpmultigpu has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def lpmultigpu(lp, lpmethod, recon, tomo, num_iter, reg_par, gpu_list, lock, ids):
          Severity: Major
          Found in source/tomopy/recon/wrappers.py - About 1 hr to fix

            Function astra has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def astra(tomo, center, recon, theta, **kwargs):
            Severity: Minor
            Found in source/tomopy/recon/wrappers.py - About 35 mins to fix

              Function lprec has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def lprec(tomo, center, recon, theta, **kwargs):
              Severity: Minor
              Found in source/tomopy/recon/wrappers.py - About 35 mins to fix

                Function ufo_fbp has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def ufo_fbp(tomo, center, recon, theta, **kwargs):
                Severity: Minor
                Found in source/tomopy/recon/wrappers.py - About 35 mins to fix

                  Function ufo_dfi has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def ufo_dfi(tomo, center, recon, theta, **kwargs):
                  Severity: Minor
                  Found in source/tomopy/recon/wrappers.py - About 35 mins to fix

                    Function lprec has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def lprec(tomo, center, recon, theta, **kwargs):
                        """
                        Reconstruct object using the Log-polar based method
                        https://github.com/math-vrn/lprec
                    
                    
                    Severity: Minor
                    Found in source/tomopy/recon/wrappers.py - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        for o in default_options['astra']:
                            if o not in opts:
                                opts[o] = default_options['astra'][o]
                    Severity: Major
                    Found in source/tomopy/recon/wrappers.py and 1 other location - About 1 hr to fix
                    source/tomopy/recon/wrappers.py on lines 387..389

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        for o in default_options['lprec']:
                            if o not in kwargs:
                                opts[o] = default_options['lprec'][o]
                    Severity: Major
                    Found in source/tomopy/recon/wrappers.py and 1 other location - About 1 hr to fix
                    source/tomopy/recon/wrappers.py on lines 143..145

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status