tomopy/tomopy

View on GitHub
source/tomopy/sim/project.py

Summary

Maintainability
D
2 days
Test Coverage

File project.py has 434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

# #########################################################################
# Copyright (c) 2015-2019, UChicago Argonne, LLC. All rights reserved.    #
Severity: Minor
Found in source/tomopy/sim/project.py - About 6 hrs to fix

    Function project3 has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def project3(
    Severity: Major
    Found in source/tomopy/sim/project.py - About 1 hr to fix

      Function project2 has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def project2(
      Severity: Major
      Found in source/tomopy/sim/project.py - About 1 hr to fix

        Function project has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def project(
        Severity: Major
        Found in source/tomopy/sim/project.py - About 1 hr to fix

          Function _get_otf has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _get_otf(dx, dy, px, py, spotsize):
          Severity: Minor
          Found in source/tomopy/sim/project.py - About 35 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if pad is True:
                    dx = _round_to_even(np.sqrt(ox * ox + oz * oz) + 2)
                elif pad is False:
                    dx = ox
            Severity: Major
            Found in source/tomopy/sim/project.py and 2 other locations - About 3 hrs to fix
            source/tomopy/sim/project.py on lines 381..384
            source/tomopy/sim/project.py on lines 448..451

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if pad is True:
                    dx = _round_to_even(np.sqrt(ox * ox + oz * oz) + 2)
                elif pad is False:
                    dx = ox
            Severity: Major
            Found in source/tomopy/sim/project.py and 2 other locations - About 3 hrs to fix
            source/tomopy/sim/project.py on lines 311..314
            source/tomopy/sim/project.py on lines 381..384

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if pad is True:
                    dx = _round_to_even(np.sqrt(ox * ox + oz * oz) + 2)
                elif pad is False:
                    dx = ox
            Severity: Major
            Found in source/tomopy/sim/project.py and 2 other locations - About 3 hrs to fix
            source/tomopy/sim/project.py on lines 311..314
            source/tomopy/sim/project.py on lines 448..451

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if not sinogram_order:
                    # rotate to radiograph order
                    tomo = np.swapaxes(tomo, 0, 1)  # doesn't copy data
                    # copy data to sharedmem
                    tomo = dtype.as_sharedmem(tomo, copy=True)
            Severity: Major
            Found in source/tomopy/sim/project.py and 2 other locations - About 50 mins to fix
            source/tomopy/sim/project.py on lines 331..335
            source/tomopy/sim/project.py on lines 464..468

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if not sinogram_order:
                    # rotate to radiograph order
                    tomo = np.swapaxes(tomo, 0, 1)  # doesn't copy data
                    # copy data to sharedmem
                    tomo = dtype.as_sharedmem(tomo, copy=True)
            Severity: Major
            Found in source/tomopy/sim/project.py and 2 other locations - About 50 mins to fix
            source/tomopy/sim/project.py on lines 396..400
            source/tomopy/sim/project.py on lines 464..468

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if not sinogram_order:
                    # rotate to radiograph order
                    tomo = np.swapaxes(tomo, 0, 1)  # doesn't copy data
                    # copy data to sharedmem
                    tomo = dtype.as_sharedmem(tomo, copy=True)
            Severity: Major
            Found in source/tomopy/sim/project.py and 2 other locations - About 50 mins to fix
            source/tomopy/sim/project.py on lines 331..335
            source/tomopy/sim/project.py on lines 396..400

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status