tomopy/tomopy

View on GitHub
source/tomopy/util/mproc.py

Summary

Maintainability
F
3 days
Test Coverage

Function distribute_jobs has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

def distribute_jobs(arr,
                    func,
                    axis,
                    args=None,
                    kwargs=None,
Severity: Minor
Found in source/tomopy/util/mproc.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File mproc.py has 292 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

# #########################################################################
# Copyright (c) 2015-2019, UChicago Argonne, LLC. All rights reserved.    #
Severity: Minor
Found in source/tomopy/util/mproc.py - About 3 hrs to fix

    Function init_shared has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def init_shared(
    Severity: Major
    Found in source/tomopy/util/mproc.py - About 1 hr to fix

      Function distribute_jobs has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def distribute_jobs(arr,
      Severity: Major
      Found in source/tomopy/util/mproc.py - About 1 hr to fix

        Function get_ncore_nchunk has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_ncore_nchunk(axis_size, ncore=None, nchunk=None):
            # limit chunk size to size of array along axis
            if nchunk and nchunk > axis_size:
                nchunk = axis_size
            # default ncore to max and limit number of cores to max number
        Severity: Minor
        Found in source/tomopy/util/mproc.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_worker_ncore_slices has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_worker_ncore_slices(axis_size, ncore=None, nchunk=None):
            # default ncore to max (also defaults ncore == 0)
            if not ncore:
                ncore = mp.cpu_count()
            if nchunk is None:
        Severity: Minor
        Found in source/tomopy/util/mproc.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if any(proc.exitcode for proc in proclist):
                                    p.terminate()
                                    raise RuntimeError(
                                        "Child process terminated before finishing")
                                res.wait(timeout=1)
        Severity: Major
        Found in source/tomopy/util/mproc.py - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if nchunk is None:
                  # calculate number of slices to send to each GPU
                  chunk_size = axis_size // ncore
                  leftover = axis_size % ncore
                  sizes = np.ones(ncore, dtype=int) * chunk_size
          Severity: Major
          Found in source/tomopy/util/mproc.py and 1 other location - About 3 hrs to fix
          source/tomopy/util/mproc.py on lines 168..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if nchunk is None:
                  # calculate number of slices to send to each GPU
                  chunk_size = axis_size // ncore
                  leftover = axis_size % ncore
                  sizes = np.ones(ncore, dtype=np.int) * chunk_size
          Severity: Major
          Found in source/tomopy/util/mproc.py and 1 other location - About 3 hrs to fix
          source/tomopy/util/mproc.py on lines 145..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  slcs = [np.s_[offsets[i]:offsets[i+1]] for i in range(offsets.shape[0]-1)]
          Severity: Major
          Found in source/tomopy/util/mproc.py and 1 other location - About 2 hrs to fix
          source/tomopy/util/mproc.py on lines 177..178

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  slcs = [np.s_[offsets[i]:offsets[i+1]]
                          for i in range(offsets.shape[0]-1)]
          Severity: Major
          Found in source/tomopy/util/mproc.py and 1 other location - About 2 hrs to fix
          source/tomopy/util/mproc.py on lines 154..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          def get_rank():
              """ Get the rank of the process """
              try:
                  from mpi4py import MPI
                  comm_w = MPI.COMM_WORLD
          Severity: Minor
          Found in source/tomopy/util/mproc.py and 1 other location - About 30 mins to fix
          source/tomopy/util/mproc.py on lines 94..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          def get_nproc():
              """ Get the number of processes """
              try:
                  from mpi4py import MPI
                  comm_w = MPI.COMM_WORLD
          Severity: Minor
          Found in source/tomopy/util/mproc.py and 1 other location - About 30 mins to fix
          source/tomopy/util/mproc.py on lines 84..91

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status