Sign upLogin

total-order/any

View on GitHub
Star

Showing 13 of 13 total issues

Function deepCompare has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

const deepCompare = (a, b) => {
    // NOTE: Shortcut.
    if (a === b) return 0;

    const left = [[a]];
Severity: Minor
Found in src/index.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deepCompare has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const deepCompare = (a, b) => {
    // NOTE: Shortcut.
    if (a === b) return 0;

    const left = [[a]];
Severity: Major
Found in src/index.js - About 3 hrs to fix

    Function comparePrimitives has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    const comparePrimitives = (kind, _a, _b) => {
    assert(kind !== 'object');
    switch (kind) {
        case 'number': {
            if (Number.isNaN(_a)) {
    Severity: Minor
    Found in src/index.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                    if (delta_keys !== 0) return delta_keys;
    Severity: Major
    Found in src/index.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return 0;
      Severity: Major
      Found in src/index.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        if (delta_regexp !== 0) return delta_regexp;
        Severity: Major
        Found in src/index.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      case RegExp: {
                const delta_regexp = compare(_a.toString(), _b.toString());
                if (delta_regexp !== 0) return delta_regexp;
                continue;
            }
          Severity: Minor
          Found in src/index.js and 1 other location - About 30 mins to fix
          src/index.js on lines 83..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                          if (delta_date !== 0) return delta_date;
          Severity: Major
          Found in src/index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            if (_a.length !== _b.length) return _a.length - _b.length;
            Severity: Major
            Found in src/index.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return compare(constructor_a.name, constructor_b.name);
              Severity: Major
              Found in src/index.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            case Date: {
                const delta_date = compare(_a.getTime(), _b.getTime());
                if (delta_date !== 0) return delta_date;
                continue;
            }
                Severity: Minor
                Found in src/index.js and 1 other location - About 30 mins to fix
                src/index.js on lines 77..81

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                            return 1;
                Severity: Major
                Found in src/index.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return compare(_a.toString(), _b.toString());
                  Severity: Major
                  Found in src/index.js - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language