Sign upLogin

trailsjs/trailpack-express

View on GitHub
Star

Showing 40 of 40 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (id) {
      response = FootprintService.find(req.params.model, id, options)
    }
    else {
      response = FootprintService.find(req.params.model, criteria, options)
Severity: Major
Found in api/controllers/FootprintController.js and 1 other location - About 1 hr to fix
api/controllers/FootprintController.js on lines 110..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createResponse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  createResponse: function(req, res, next) {
    const response = (data) => {

      return new Promise((resolve, reject) => {
        if (!data) {
Severity: Minor
Found in lib/utils.js - About 1 hr to fix

    Function findAssociation has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      findAssociation(req, res) {
    const FootprintService = this.app.services.FootprintService
    const options = this.app.packs.express.getOptionsFromQuery(req.query)
    const criteria = this.app.packs.express.getCriteriaFromQuery(req.query)
    const parentModel = req.params.parentModel
    Severity: Minor
    Found in api/controllers/FootprintController.js - About 1 hr to fix

      Function destroyAssociation has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        destroyAssociation(req, res) {
    const FootprintService = this.app.services.FootprintService
    const options = this.app.packs.express.getOptionsFromQuery(req.query)
    const criteria = this.app.packs.express.getCriteriaFromQuery(req.query)
    const parentModel = req.params.parentModel
      Severity: Minor
      Found in api/controllers/FootprintController.js - About 1 hr to fix

        Function updateAssociation has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          updateAssociation(req, res) {
    const FootprintService = this.app.services.FootprintService
    const options = this.app.packs.express.getOptionsFromQuery(req.query)
    const criteria = this.app.packs.express.getCriteriaFromQuery(req.query)
    const parentModel = req.params.parentModel
        Severity: Minor
        Found in api/controllers/FootprintController.js - About 1 hr to fix

          Function createResponse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            createResponse: function(req, res, next) {
    const response = (data) => {

      return new Promise((resolve, reject) => {
        if (!data) {
          Severity: Minor
          Found in lib/utils.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            update(req, res) {
    const FootprintService = this.app.services.FootprintService
    const options = this.app.packs.express.getOptionsFromQuery(req.query)
    const criteria = this.app.packs.express.getCriteriaFromQuery(req.query)
    const id = req.params.id
          Severity: Minor
          Found in api/controllers/FootprintController.js - About 1 hr to fix

            Function registerMiddlewares has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              registerMiddlewares(app, server) {
    server.use(expressBoom())
    if (this.cors) {
      server.use(cors(this.cors === true ? {} : this.cors))
    }
            Severity: Minor
            Found in lib/server.js - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                            if (joinedA > joinedB) {
                return asc ? 1 : -1
              }
              Severity: Major
              Found in lib/utils.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                              if (joinedA < joinedB) {
                return asc ? -1 : 1
              }
                Severity: Major
                Found in lib/utils.js - About 45 mins to fix

                  Function createServer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    createServer(app) {
    const main = app.config.get('main')
    const sess = app.config.get('session')
    const express = app.config.get('web.express')
                  Severity: Minor
                  Found in lib/server.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (childId) {
      response = FootprintService.destroyAssociation(parentModel,
        parentId, childAttribute, childId, options)
    }
    else {
                  Severity: Minor
                  Found in api/controllers/FootprintController.js and 1 other location - About 40 mins to fix
                  api/controllers/FootprintController.js on lines 161..168

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (childId) {
      response = FootprintService.findAssociation(parentModel,
        parentId, childAttribute, childId, options)
    }
    else {
                  Severity: Minor
                  Found in api/controllers/FootprintController.js and 1 other location - About 40 mins to fix
                  api/controllers/FootprintController.js on lines 227..234

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Avoid too many return statements within this function.
                  Open

                                  return asc ? 1 : -1
                  Severity: Major
                  Found in lib/utils.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return asc ? -1 : 1
                    Severity: Major
                    Found in lib/utils.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                    return asc ? -1 : 1
                      Severity: Major
                      Found in lib/utils.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return 0
                        Severity: Major
                        Found in lib/utils.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return asc ? -1 : 1
                          Severity: Major
                          Found in lib/utils.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                          return asc ? 1 : -1
                            Severity: Major
                            Found in lib/utils.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                          return asc ? 1 : -1
                              Severity: Major
                              Found in lib/utils.js - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language