trailsjs/trailpack-express

View on GitHub
lib/utils.js

Summary

Maintainability
F
3 days
Test Coverage

Function createSpecificityComparator has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
Open

  createSpecificityComparator: function(options) {
    const self = this
    options = options || {}
    // Ascending order flag, defaults to false
    let asc = false
Severity: Minor
Found in lib/utils.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createSpecificityComparator has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  createSpecificityComparator: function(options) {
    const self = this
    options = options || {}
    // Ascending order flag, defaults to false
    let asc = false
Severity: Major
Found in lib/utils.js - About 2 hrs to fix

    Function specificityComparator has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        return function specificityComparator(routeA, routeB) {
          routeA = (routeA.path || '').toLowerCase()
          routeB = (routeB.path || '').toLowerCase()
          // If it's the default route, push it all the way
          // over to one of the ends
    Severity: Minor
    Found in lib/utils.js - About 1 hr to fix

      Function createResponse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        createResponse: function(req, res, next) {
          const response = (data) => {
      
            return new Promise((resolve, reject) => {
              if (!data) {
      Severity: Minor
      Found in lib/utils.js - About 1 hr to fix

        Function createResponse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          createResponse: function(req, res, next) {
            const response = (data) => {
        
              return new Promise((resolve, reject) => {
                if (!data) {
        Severity: Minor
        Found in lib/utils.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                      if (joinedA > joinedB) {
                        return asc ? 1 : -1
                      }
        Severity: Major
        Found in lib/utils.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        if (joinedA < joinedB) {
                          return asc ? -1 : 1
                        }
          Severity: Major
          Found in lib/utils.js - About 45 mins to fix

            Avoid too many return statements within this function.
            Open

                            return asc ? 1 : -1
            Severity: Major
            Found in lib/utils.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return asc ? -1 : 1
              Severity: Major
              Found in lib/utils.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                              return asc ? -1 : 1
                Severity: Major
                Found in lib/utils.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return 0
                  Severity: Major
                  Found in lib/utils.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return asc ? -1 : 1
                    Severity: Major
                    Found in lib/utils.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                    return asc ? 1 : -1
                      Severity: Major
                      Found in lib/utils.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return asc ? 1 : -1
                        Severity: Major
                        Found in lib/utils.js - About 30 mins to fix

                          There are no issues that match your filters.

                          Category
                          Status