Sign upLogin

treasure-data/embulk-input-zendesk

View on GitHub
Star

Showing 49 of 49 total issues

File ZendeskInputPlugin.java has 515 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.embulk.input.zendesk;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ArrayNode;
Severity: Major
Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 1 day to fix

    Method importDataForIncremental has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
    Open

        private void importDataForIncremental(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;
        long startTime = 0;
        long endTime = Long.MAX_VALUE;
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method isResponseStatusToRetry has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        private boolean isResponseStatusToRetry(final int status, final String message, final int retryAfter, final boolean isPreview)
    {
        if (status == HttpStatus.SC_NOT_FOUND) {
            ObjectMapper objectMapper = new ObjectMapper();
            try {
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addAllColumnsToSchema has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        private JsonNode addAllColumnsToSchema(final JsonNode jsonNode, final Target target, final List<String> includes)
    {
        ConfigDiff configDiff = guessData(jsonNode, target.getJsonName());
        ConfigDiff parser = configDiff.getNested("parser");
        if (parser.has("columns")) {
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method importDataForIncremental has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void importDataForIncremental(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;
        long startTime = 0;
        long endTime = Long.MAX_VALUE;
    Severity: Major
    Found in src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java - About 3 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private void fetchSubResourceAndAddToImporter(final JsonNode jsonNode, final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter)
    {
        task.getIncludes().forEach(include -> {
            final String relatedObjectName = include.trim();
      Severity: Major
      Found in src/main/java/org/embulk/input/zendesk/services/ZendeskCursorBasedService.java and 1 other location - About 3 hrs to fix
      src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java on lines 228..253

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 198.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private void fetchSubResourceAndAddToImporter(final JsonNode jsonNode, final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter)
    {
        task.getIncludes().forEach(include -> {
            final String relatedObjectName = include.trim();
      Severity: Major
      Found in src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java and 1 other location - About 3 hrs to fix
      src/main/java/org/embulk/input/zendesk/services/ZendeskCursorBasedService.java on lines 147..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 198.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      ZendeskInputPlugin has 26 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class ZendeskInputPlugin
    implements InputPlugin
{
    public interface PluginTask
        extends Task
      Severity: Minor
      Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 3 hrs to fix

        Method addRecord has 72 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public synchronized void addRecord(final JsonNode record)
    {
        schema.visitColumns(new ColumnVisitor()
        {
            @Override
        Severity: Major
        Found in src/main/java/org/embulk/input/zendesk/RecordImporter.java - About 2 hrs to fix

          PluginTask has 24 methods (exceeds 20 allowed). Consider refactoring.
          Open

              public interface PluginTask
        extends Task
    {
        @Config("login_url")
        String getLoginUrl();
          Severity: Minor
          Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 2 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private void storeStartTimeForConfigDiff(final TaskReport taskReport, final long initStartTime, final long resultEndTime)
    {
        if (task.getIncremental()) {
            long nextStartTime;
            long now = Instant.now().getEpochSecond();
            Severity: Major
            Found in src/main/java/org/embulk/input/zendesk/services/ZendeskChatService.java and 1 other location - About 2 hrs to fix
            src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java on lines 197..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 166.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private void storeStartTimeForConfigDiff(final TaskReport taskReport, final long initStartTime, final long resultEndTime)
    {
        if (task.getIncremental()) {
            long nextStartTime;
            long now = Instant.now().getEpochSecond();
            Severity: Major
            Found in src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java and 1 other location - About 2 hrs to fix
            src/main/java/org/embulk/input/zendesk/services/ZendeskChatService.java on lines 233..262

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 166.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method importData has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                private void importData(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;

        if (task.getStartTime().isPresent()) {
            Severity: Minor
            Found in src/main/java/org/embulk/input/zendesk/services/ZendeskCursorBasedService.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method doGet has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public String doGet(final String url, final PluginTask task, final boolean isPreview)
    {
        target = task.getTarget();
        loginURL = task.getLoginUrl();
            Severity: Major
            Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 2 hrs to fix

              Method isResponseStatusToRetry has 56 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private boolean isResponseStatusToRetry(final int status, final String message, final int retryAfter, final boolean isPreview)
    {
        if (status == HttpStatus.SC_NOT_FOUND) {
            ObjectMapper objectMapper = new ObjectMapper();
            try {
              Severity: Major
              Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 2 hrs to fix

                File ZendeskRestClient.java has 256 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                package org.embulk.input.zendesk.clients;

import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
                Severity: Minor
                Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 2 hrs to fix

                  Method importData has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private void importData(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;

        if (task.getStartTime().isPresent()) {
                  Severity: Minor
                  Found in src/main/java/org/embulk/input/zendesk/services/ZendeskCursorBasedService.java - About 1 hr to fix

                    Method addAllColumnsToSchema has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private JsonNode addAllColumnsToSchema(final JsonNode jsonNode, final Target target, final List<String> includes)
    {
        ConfigDiff configDiff = guessData(jsonNode, target.getJsonName());
        ConfigDiff parser = configDiff.getNested("parser");
        if (parser.has("columns")) {
                    Severity: Minor
                    Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 1 hr to fix

                      Method buildConfigDiff has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private ConfigDiff buildConfigDiff(final PluginTask task, final List<TaskReport> taskReports)
    {
        final ConfigDiff configDiff = CONFIG_MAPPER_FACTORY.newConfigDiff();

        if (!taskReports.isEmpty() && task.getIncremental()) {
                      Severity: Minor
                      Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if (taskReport.has(ZendeskConstants.Field.START_TIME)) {
                final Long startTime = taskReport.get(Long.class, ZendeskConstants.Field.START_TIME);
                if (startTime != null) {
                    final OffsetDateTime offsetDateTime = OffsetDateTime.ofInstant(Instant.ofEpochSecond(startTime), ZoneOffset.UTC);
                    configDiff.set(ZendeskConstants.Field.START_TIME,
                      Severity: Major
                      Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java and 1 other location - About 1 hr to fix
                      src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java on lines 278..285

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 88.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language