Sign upLogin

treasure-data/embulk-input-zendesk

View on GitHub
Star

Showing 31 of 49 total issues

File ZendeskInputPlugin.java has 515 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.embulk.input.zendesk;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ArrayNode;
Severity: Major
Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 1 day to fix

    Method importDataForIncremental has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
    Open

        private void importDataForIncremental(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;
        long startTime = 0;
        long endTime = Long.MAX_VALUE;
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method isResponseStatusToRetry has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        private boolean isResponseStatusToRetry(final int status, final String message, final int retryAfter, final boolean isPreview)
    {
        if (status == HttpStatus.SC_NOT_FOUND) {
            ObjectMapper objectMapper = new ObjectMapper();
            try {
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addAllColumnsToSchema has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        private JsonNode addAllColumnsToSchema(final JsonNode jsonNode, final Target target, final List<String> includes)
    {
        ConfigDiff configDiff = guessData(jsonNode, target.getJsonName());
        ConfigDiff parser = configDiff.getNested("parser");
        if (parser.has("columns")) {
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method importDataForIncremental has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void importDataForIncremental(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;
        long startTime = 0;
        long endTime = Long.MAX_VALUE;
    Severity: Major
    Found in src/main/java/org/embulk/input/zendesk/services/ZendeskNormalServices.java - About 3 hrs to fix

      ZendeskInputPlugin has 26 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class ZendeskInputPlugin
    implements InputPlugin
{
    public interface PluginTask
        extends Task
      Severity: Minor
      Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 3 hrs to fix

        Method addRecord has 72 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public synchronized void addRecord(final JsonNode record)
    {
        schema.visitColumns(new ColumnVisitor()
        {
            @Override
        Severity: Major
        Found in src/main/java/org/embulk/input/zendesk/RecordImporter.java - About 2 hrs to fix

          PluginTask has 24 methods (exceeds 20 allowed). Consider refactoring.
          Open

              public interface PluginTask
        extends Task
    {
        @Config("login_url")
        String getLoginUrl();
          Severity: Minor
          Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 2 hrs to fix

            Method importData has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                private void importData(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;

        if (task.getStartTime().isPresent()) {
            Severity: Minor
            Found in src/main/java/org/embulk/input/zendesk/services/ZendeskCursorBasedService.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method doGet has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public String doGet(final String url, final PluginTask task, final boolean isPreview)
    {
        target = task.getTarget();
        loginURL = task.getLoginUrl();
            Severity: Major
            Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 2 hrs to fix

              Method isResponseStatusToRetry has 56 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private boolean isResponseStatusToRetry(final int status, final String message, final int retryAfter, final boolean isPreview)
    {
        if (status == HttpStatus.SC_NOT_FOUND) {
            ObjectMapper objectMapper = new ObjectMapper();
            try {
              Severity: Major
              Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 2 hrs to fix

                File ZendeskRestClient.java has 256 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                package org.embulk.input.zendesk.clients;

import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
                Severity: Minor
                Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 2 hrs to fix

                  Method importData has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private void importData(final ZendeskInputPlugin.PluginTask task, final RecordImporter recordImporter, final TaskReport taskReport)
    {
        long initStartTime = 0;

        if (task.getStartTime().isPresent()) {
                  Severity: Minor
                  Found in src/main/java/org/embulk/input/zendesk/services/ZendeskCursorBasedService.java - About 1 hr to fix

                    Method addAllColumnsToSchema has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private JsonNode addAllColumnsToSchema(final JsonNode jsonNode, final Target target, final List<String> includes)
    {
        ConfigDiff configDiff = guessData(jsonNode, target.getJsonName());
        ConfigDiff parser = configDiff.getNested("parser");
        if (parser.has("columns")) {
                    Severity: Minor
                    Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 1 hr to fix

                      Method buildConfigDiff has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private ConfigDiff buildConfigDiff(final PluginTask task, final List<TaskReport> taskReports)
    {
        final ConfigDiff configDiff = CONFIG_MAPPER_FACTORY.newConfigDiff();

        if (!taskReports.isEmpty() && task.getIncremental()) {
                      Severity: Minor
                      Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method createSampleData has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private List<List<Object>> createSampleData(JsonNode jsonNode, String targetJsonName, List<String> unifiedFieldNames)
    {
        final List<List<Object>> samples = new ArrayList<>();
        Iterator<JsonNode> records = ZendeskUtils.getListRecords(jsonNode, targetJsonName);
        while (records.hasNext()) {
                      Severity: Minor
                      Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method addRecordToImporter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          @Override
    public TaskReport addRecordToImporter(final int taskIndex, final RecordImporter recordImporter)
    {
        final TaskReport taskReport = CONFIG_MAPPER_FACTORY.newTaskReport();
        String startTime = getStartTime();
                      Severity: Minor
                      Found in src/main/java/org/embulk/input/zendesk/services/ZendeskChatService.java - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method addRecordToImporter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          @Override
    public TaskReport addRecordToImporter(final int taskIndex, final RecordImporter recordImporter)
    {
        final TaskReport taskReport = CONFIG_MAPPER_FACTORY.newTaskReport();
        String startTime = getStartTime();
                      Severity: Minor
                      Found in src/main/java/org/embulk/input/zendesk/services/ZendeskChatService.java - About 1 hr to fix

                        Method sendGetRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private String sendGetRequest(final String url, final PluginTask task)
        throws ZendeskException
    {
        try {
            final HttpClient client = createHttpClient();
                        Severity: Minor
                        Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method storeStartTimeForConfigDiff has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private void storeStartTimeForConfigDiff(final TaskReport taskReport, final long initStartTime, final long resultEndTime)
    {
        if (task.getIncremental()) {
            long nextStartTime;
            long now = Instant.now().getEpochSecond();
                        Severity: Minor
                        Found in src/main/java/org/embulk/input/zendesk/services/ZendeskChatService.java - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language