trusona/trusona-server-sdk-ruby

View on GitHub

Showing 4 of 6 total issues

Method validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def validate
        raise ArgumentError unless @path
        raise ArgumentError unless @body
        raise ArgumentError unless @method
        raise ArgumentError unless @host
Severity: Minor
Found in lib/trusona/api/signed_request.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return nil if time.is_a?(Date)
Severity: Major
Found in lib/trusona/helpers/time_normalizer.rb - About 30 mins to fix

    Method determine_request_content_type has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def determine_request_content_type
            default_type = 'application/json;charset=utf-8'
            return default_type unless @unverified.request
            return default_type unless @unverified.request.options
            return default_type unless @unverified.request.options[:headers]
    Severity: Minor
    Found in lib/trusona/api/verified_response.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handle_block has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def handle_block(trusonafication, service, timeout, block)
            timeout ||= DEFAULT_TIMEOUT
    
            future = Time.now.to_i + timeout
            while Time.now.to_i < future
    Severity: Minor
    Found in lib/trusona/workers/trusonafication_creator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language