twbs/bootstrap

View on GitHub

Showing 92 of 92 total issues

Function checkPosition has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  Affix.prototype.checkPosition = function () {
    if (!this.$element.is(':visible')) return

    var height       = this.$element.height()
    var offset       = this.options.offset
Severity: Minor
Found in js/affix.js - About 1 hr to fix

    Function exports has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function (config) {
      var conf = {
        basePath: '../',
        frameworks: ['qunit'],
        plugins: ['karma-qunit'],
    Severity: Minor
    Found in grunt/karma.conf.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function main(args) {
      if (args.length !== 2) {
        console.error('USAGE: change-version old_version new_version');
        console.error('Got arguments:', args);
        process.exit(1);
    Severity: Minor
    Found in grunt/change-version.js - About 1 hr to fix

      Function walkAsync has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function walkAsync(directory, excludedDirectories, fileCallback, errback) {
        if (excludedDirectories.has(path.parse(directory).base)) {
          return;
        }
        fs.readdir(directory, function (err, names) {
      Severity: Minor
      Found in grunt/change-version.js - About 1 hr to fix

        Function next has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function next() {
              $active
                .removeClass('active')
                .find('> .dropdown-menu > .active')
                .removeClass('active')
        Severity: Minor
        Found in docs/dist/js/bootstrap.js - About 1 hr to fix

          Function refresh has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            ScrollSpy.prototype.refresh = function () {
              var that          = this
              var offsetMethod  = 'offset'
              var offsetBase    = 0
          
          
          Severity: Minor
          Found in docs/dist/js/bootstrap.js - About 1 hr to fix

            Function refresh has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              ScrollSpy.prototype.refresh = function () {
                var that          = this
                var offsetMethod  = 'offset'
                var offsetBase    = 0
            
            
            Severity: Minor
            Found in js/scrollspy.js - About 1 hr to fix

              Function hide has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                Collapse.prototype.hide = function () {
                  if (this.transitioning || !this.$element.hasClass('in')) return
              
                  var startEvent = $.Event('hide.bs.collapse')
                  this.$element.trigger(startEvent)
              Severity: Minor
              Found in js/collapse.js - About 1 hr to fix

                Function next has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function next() {
                      $active
                        .removeClass('active')
                        .find('> .dropdown-menu > .active')
                        .removeClass('active')
                Severity: Minor
                Found in js/tab.js - About 1 hr to fix

                  Function hide has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    Collapse.prototype.hide = function () {
                      if (this.transitioning || !this.$element.hasClass('in')) return
                  
                      var startEvent = $.Event('hide.bs.collapse')
                      this.$element.trigger(startEvent)
                  Severity: Minor
                  Found in docs/dist/js/bootstrap.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      $('#plugin-section .toggle').on('click', function (e) {
                        e.preventDefault()
                        $inputsPlugin.prop('checked', !$inputsPlugin.is(':checked'))
                      })
                    Severity: Minor
                    Found in docs/assets/js/src/customizer.js and 1 other location - About 55 mins to fix
                    docs/assets/js/src/customizer.js on lines 342..345

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 54.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      $('#less-section .toggle').on('click', function (e) {
                        e.preventDefault()
                        $inputsComponent.prop('checked', !$inputsComponent.is(':checked'))
                      })
                    Severity: Minor
                    Found in docs/assets/js/src/customizer.js and 1 other location - About 55 mins to fix
                    docs/assets/js/src/customizer.js on lines 347..350

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 54.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function parseSubSections has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                    Parser.prototype.parseSubSections = function (section) {
                      while (true) {
                        var subsection = this.parseSubSection();
                        if (subsection === null) {
                          if (section.subsections.length === 0) {
                    Severity: Minor
                    Found in grunt/bs-lessdoc-parser.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _shift has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                    Tokenizer.prototype._shift = function () {
                      // returning null signals EOF
                      // returning undefined means the line was ignored
                      if (this._next !== undefined) {
                        var result = this._next;
                    Severity: Minor
                    Found in grunt/bs-lessdoc-parser.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method bugify has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def bugify(input)
                          upstream_map = {
                            "Bootstrap" => "https://github.com/twbs/bootstrap/issues/",
                            "Edge" => ["https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/", "Edge issue"],
                            "UserVoice" => ["https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/", "Edge UserVoice idea"],
                    Severity: Minor
                    Found in docs/_plugins/bugify.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (css) {
                          var cssFolder = zip.folder('css')
                          for (var fileName in css) {
                            cssFolder.file(fileName, css[fileName])
                          }
                    Severity: Minor
                    Found in docs/assets/js/src/customizer.js and 1 other location - About 50 mins to fix
                    docs/assets/js/src/customizer.js on lines 113..118

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 51.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (js) {
                          var jsFolder = zip.folder('js')
                          for (var jsFileName in js) {
                            jsFolder.file(jsFileName, js[jsFileName])
                          }
                    Severity: Minor
                    Found in docs/assets/js/src/customizer.js and 1 other location - About 50 mins to fix
                    docs/assets/js/src/customizer.js on lines 106..111

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 51.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function replaceRecursively has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function replaceRecursively(directory, excludedDirectories, allowedExtensions, original, replacement) {
                      original = new RegExp(RegExp.quote(original), 'g');
                      replacement = RegExp.quoteReplacement(replacement);
                      var updateFile = !DRY_RUN ? function (filepath) {
                        if (allowedExtensions.has(path.parse(filepath).ext)) {
                    Severity: Minor
                    Found in grunt/change-version.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Consider simplifying this complex logical expression.
                    Open

                      if ((version[0] < 2 && version[1] < 9) || (version[0] == 1 && version[1] == 9 && version[2] < 1) || (version[0] > 3)) {
                        throw new Error('Bootstrap\'s JavaScript requires jQuery version 1.9.1 or higher, but lower than version 4')
                      }
                    Severity: Major
                    Found in docs/dist/js/bootstrap.js - About 40 mins to fix

                      Function replaceRecursively has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function replaceRecursively(directory, excludedDirectories, allowedExtensions, original, replacement) {
                      Severity: Minor
                      Found in grunt/change-version.js - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language