twers/re-education

Function `factory` has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  .directive('fileUploader', ['plupload', function factory(pluploader) {

    function link(scope, tElement, tAttrs, transclude) {

      var selectBtn = angular.element('#' + tAttrs.browseBtnId);

Found in app/assets/javascripts/directives/openclass.fileuploader.js - About 3 hrs to fix

Function `CommentsController` has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function CommentsController($scope, $element, CommentResource) {
  var CommentResources;

  $scope.init = function(lessonplanId) {
    Comment = CommentResource(lessonplanId);

Found in app/assets/javascripts/angular/controllers/comments.controller.js - About 2 hrs to fix

Function `factory` has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      function factory(eventConstants, base64) {

        var auth = $('[name="qiniu-request-token"]').attr('content'),
          qiniuDomain = 'http://newclass.qiniudn.com';

Found in app/assets/javascripts/directives/openclass.jquery.fileuploader.js - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  $scope.init = function (lessonplanId) {
    Task = TaskResource(lessonplanId);

    Task.query(function (tasks) {
      $scope.tasks = tasks;

Found in app/assets/javascripts/angular/controllers/tasks.controller.js and 1 other location - About 2 hrs to fix

Read up
Read up

app/assets/javascripts/angular/controllers/comments.controller.js on lines 4..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `link` has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function link(scope, tElement, tAttrs, transclude) {

      var selectBtn = angular.element('#' + tAttrs.browseBtnId);
      var fileList = tElement.find('.fileList').hide();

Found in app/assets/javascripts/directives/openclass.fileuploader.js - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  $scope.init = function(lessonplanId) {
    Comment = CommentResource(lessonplanId);

    Comment.query(function(comments) {
      $scope.comments = comments;

Found in app/assets/javascripts/angular/controllers/comments.controller.js and 1 other location - About 2 hrs to fix

Read up
Read up

app/assets/javascripts/angular/controllers/tasks.controller.js on lines 5..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `factory` has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  .directive('wysihtml5', ['$timeout', 'eventConstants', function factory($timeout, eventConstants) {

    var directive = {
      restrict: 'C',
      require: '?ngModel',

Found in app/assets/javascripts/directives/openclass.wysihtml5.editor.js - About 2 hrs to fix

Function `link` has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      link: function (scope, element, attrs, ngModelCtrl) {

        var editor = new wysihtml5.Editor(element.get(0), {
          parserRules: wysihtml5ParserRules,
          toolbar: element.siblings('.toolbar').get(0),

Found in app/assets/javascripts/directives/openclass.wysihtml5.editor.js - About 1 hr to fix

Function `factory` has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

.directive('gallery', function factory(fancybox) {
  var directive = {
    restrict: 'C',
    link: function (scope, element, attrs) {
      scope.$watch('attachments', function (attachments) {

Found in app/assets/javascripts/directives/openclass.gallery.js - About 1 hr to fix

Function `CommentsController` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function CommentsController($scope, $element, CommentResource) {
  var CommentResources;

  $scope.init = function(lessonplanId) {
    Comment = CommentResource(lessonplanId);

Found in app/assets/javascripts/angular/controllers/comments.controller.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `link` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    link: function (scope, element, attrs) {
      scope.$watch('attachments', function (attachments) {
        if (attachments) {
          fancybox(element.find('a'), {
            afterShow: function() {

Found in app/assets/javascripts/directives/openclass.gallery.js - About 1 hr to fix

Function `AvatarPickerController` has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function AvatarPickerController($scope, $element){

  $scope.init = function(){
    $scope.selectedImgUrl = getCurrentSelectedRadioElem().val();
  };

Found in app/assets/javascripts/angular/controllers/avatar.picker.controller.js - About 1 hr to fix

Function `factory` has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  .directive('fileUploader', ['plupload', function factory(pluploader) {

    function link(scope, tElement, tAttrs, transclude) {

      var selectBtn = angular.element('#' + tAttrs.browseBtnId);

Found in app/assets/javascripts/directives/openclass.fileuploader.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `AttachmentController` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function AttachmentController($scope, AttachmentResource) {

  var Attachment;

  function loadAttachments(Attachment, type) {

Found in app/assets/javascripts/angular/controllers/attachment.controller.js - About 1 hr to fix

Method `index` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    if request.headers['X-Requested-With'] == "XMLHttpRequest"
      file_type = params[:file_type]
      file_type = :images.to_s if file_type.nil?

Found in app/controllers/lessonplan_attachments_controller.rb - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `CachedTasksController` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function CachedTasksController($scope, TaskResource) {

  $scope.cachedTasks = [];

  var Task;

Found in app/assets/javascripts/angular/controllers/cached.tasks.controller.js - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `initialize` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def initialize(user)
    user ||= Publisher.new # guest user (not logged in)

    can :read, :all
    can :create, Publisher if user.id.nil?

Found in app/models/ability.rb - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `AvatarPickerController` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function AvatarPickerController($scope, $element){

  $scope.init = function(){
    $scope.selectedImgUrl = getCurrentSelectedRadioElem().val();
  };

Found in app/assets/javascripts/angular/controllers/avatar.picker.controller.js - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading