twers/re-education

View on GitHub

Showing 16 of 18 total issues

Function factory has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  .directive('fileUploader', ['plupload', function factory(pluploader) {

    function link(scope, tElement, tAttrs, transclude) {

      var selectBtn = angular.element('#' + tAttrs.browseBtnId);
Severity: Major
Found in app/assets/javascripts/directives/openclass.fileuploader.js - About 3 hrs to fix

    Function CommentsController has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function CommentsController($scope, $element, CommentResource) {
      var CommentResources;
    
      $scope.init = function(lessonplanId) {
        Comment = CommentResource(lessonplanId);
    Severity: Major
    Found in app/assets/javascripts/angular/controllers/comments.controller.js - About 2 hrs to fix

      Function factory has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            function factory(eventConstants, base64) {
      
              var auth = $('[name="qiniu-request-token"]').attr('content'),
                qiniuDomain = 'http://newclass.qiniudn.com';
      
      
      Severity: Major
      Found in app/assets/javascripts/directives/openclass.jquery.fileuploader.js - About 2 hrs to fix

        Function link has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function link(scope, tElement, tAttrs, transclude) {
        
              var selectBtn = angular.element('#' + tAttrs.browseBtnId);
              var fileList = tElement.find('.fileList').hide();
        
        
        Severity: Major
        Found in app/assets/javascripts/directives/openclass.fileuploader.js - About 2 hrs to fix

          Function factory has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            .directive('wysihtml5', ['$timeout', 'eventConstants', function factory($timeout, eventConstants) {
          
              var directive = {
                restrict: 'C',
                require: '?ngModel',
          Severity: Major
          Found in app/assets/javascripts/directives/openclass.wysihtml5.editor.js - About 2 hrs to fix

            Function link has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  link: function (scope, element, attrs, ngModelCtrl) {
            
                    var editor = new wysihtml5.Editor(element.get(0), {
                      parserRules: wysihtml5ParserRules,
                      toolbar: element.siblings('.toolbar').get(0),
            Severity: Minor
            Found in app/assets/javascripts/directives/openclass.wysihtml5.editor.js - About 1 hr to fix

              Function factory has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              .directive('gallery', function factory(fancybox) {
                var directive = {
                  restrict: 'C',
                  link: function (scope, element, attrs) {
                    scope.$watch('attachments', function (attachments) {
              Severity: Minor
              Found in app/assets/javascripts/directives/openclass.gallery.js - About 1 hr to fix

                Function CommentsController has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                function CommentsController($scope, $element, CommentResource) {
                  var CommentResources;
                
                  $scope.init = function(lessonplanId) {
                    Comment = CommentResource(lessonplanId);
                Severity: Minor
                Found in app/assets/javascripts/angular/controllers/comments.controller.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function link has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    link: function (scope, element, attrs) {
                      scope.$watch('attachments', function (attachments) {
                        if (attachments) {
                          fancybox(element.find('a'), {
                            afterShow: function() {
                Severity: Minor
                Found in app/assets/javascripts/directives/openclass.gallery.js - About 1 hr to fix

                  Function AvatarPickerController has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function AvatarPickerController($scope, $element){
                  
                    $scope.init = function(){
                      $scope.selectedImgUrl = getCurrentSelectedRadioElem().val();
                    };

                    Function factory has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                      .directive('fileUploader', ['plupload', function factory(pluploader) {
                    
                        function link(scope, tElement, tAttrs, transclude) {
                    
                          var selectBtn = angular.element('#' + tAttrs.browseBtnId);
                    Severity: Minor
                    Found in app/assets/javascripts/directives/openclass.fileuploader.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function AttachmentController has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function AttachmentController($scope, AttachmentResource) {
                    
                      var Attachment;
                    
                      function loadAttachments(Attachment, type) {
                    Severity: Minor
                    Found in app/assets/javascripts/angular/controllers/attachment.controller.js - About 1 hr to fix

                      Method index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def index
                          if request.headers['X-Requested-With'] == "XMLHttpRequest"
                            file_type = params[:file_type]
                            file_type = :images.to_s if file_type.nil?
                      
                      
                      Severity: Minor
                      Found in app/controllers/lessonplan_attachments_controller.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function CachedTasksController has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function CachedTasksController($scope, TaskResource) {
                      
                        $scope.cachedTasks = [];
                      
                        var Task;
                      Severity: Minor
                      Found in app/assets/javascripts/angular/controllers/cached.tasks.controller.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def initialize(user)
                          user ||= Publisher.new # guest user (not logged in)
                      
                          can :read, :all
                          can :create, Publisher if user.id.nil?
                      Severity: Minor
                      Found in app/models/ability.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function AvatarPickerController has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function AvatarPickerController($scope, $element){
                      
                        $scope.init = function(){
                          $scope.selectedImgUrl = getCurrentSelectedRadioElem().val();
                        };
                      Severity: Minor
                      Found in app/assets/javascripts/angular/controllers/avatar.picker.controller.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language