Sign upLogin

twitter/clockworkraven

View on GitHub
Star

Showing 66 of 66 total issues

File bootstrap.js has 1281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* ===================================================
 * bootstrap-transition.js v2.0.4
 * http://twitter.github.com/bootstrap/javascript.html#transitions
 * ===================================================
 * Copyright 2012 Twitter, Inc.
Severity: Major
Found in app/assets/javascripts/lib/bootstrap.js - About 3 days to fix

    File ColVis.js has 484 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * File:        ColVis.js
 * Version:     1.0.7
 * CVS:         $Id$
 * Description: Controls for column visiblity in DataTables
    Severity: Minor
    Found in app/assets/javascripts/lib/ColVis.js - About 7 hrs to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        $.fn.tooltip = function ( option ) {
    return this.each(function () {
      var $this = $(this)
        , data = $this.data('tooltip')
        , options = typeof option == 'object' && option
      Severity: Major
      Found in app/assets/javascripts/lib/bootstrap.js and 3 other locations - About 4 hrs to fix
      app/assets/javascripts/lib/bootstrap.js on lines 521..529
      app/assets/javascripts/lib/bootstrap.js on lines 1343..1351
      app/assets/javascripts/lib/bootstrap.js on lines 1748..1756

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        $.fn.collapse = function (option) {
    return this.each(function () {
      var $this = $(this)
        , data = $this.data('collapse')
        , options = typeof option == 'object' && option
      Severity: Major
      Found in app/assets/javascripts/lib/bootstrap.js and 3 other locations - About 4 hrs to fix
      app/assets/javascripts/lib/bootstrap.js on lines 1107..1115
      app/assets/javascripts/lib/bootstrap.js on lines 1343..1351
      app/assets/javascripts/lib/bootstrap.js on lines 1748..1756

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        $.fn.typeahead = function (option) {
    return this.each(function () {
      var $this = $(this)
        , data = $this.data('typeahead')
        , options = typeof option == 'object' && option
      Severity: Major
      Found in app/assets/javascripts/lib/bootstrap.js and 3 other locations - About 4 hrs to fix
      app/assets/javascripts/lib/bootstrap.js on lines 521..529
      app/assets/javascripts/lib/bootstrap.js on lines 1107..1115
      app/assets/javascripts/lib/bootstrap.js on lines 1343..1351

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        $.fn.scrollspy = function ( option ) {
    return this.each(function () {
      var $this = $(this)
        , data = $this.data('scrollspy')
        , options = typeof option == 'object' && option
      Severity: Major
      Found in app/assets/javascripts/lib/bootstrap.js and 3 other locations - About 4 hrs to fix
      app/assets/javascripts/lib/bootstrap.js on lines 521..529
      app/assets/javascripts/lib/bootstrap.js on lines 1107..1115
      app/assets/javascripts/lib/bootstrap.js on lines 1748..1756

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        $.fn.alert = function (option) {
    return this.each(function () {
      var $this = $(this)
        , data = $this.data('alert')
      if (!data) $this.data('alert', (data = new Alert(this)))
      Severity: Major
      Found in app/assets/javascripts/lib/bootstrap.js and 1 other location - About 3 hrs to fix
      app/assets/javascripts/lib/bootstrap.js on lines 625..632

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        $.fn.dropdown = function (option) {
    return this.each(function () {
      var $this = $(this)
        , data = $this.data('dropdown')
      if (!data) $this.data('dropdown', (data = new Dropdown(this)))
      Severity: Major
      Found in app/assets/javascripts/lib/bootstrap.js and 1 other location - About 3 hrs to fix
      app/assets/javascripts/lib/bootstrap.js on lines 126..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method fetch_results has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

          def fetch_results task
      hit_id = task.mturk_hit
      return unless hit_id
      assignments = mturk_run{mturk(task.evaluation).getAssignmentsForHIT :HITId => hit_id}
      # return if we don't have a response from a MTurk user
      Severity: Minor
      Found in lib/m_turk_utils.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File m_turk_utils.rb has 328 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module MTurkUtils
  # Basic structure of the XML structure for an HTML question.
  HTML_QUESTION_XML = <<-END_XML
    <HTMLQuestion xmlns="http://mechanicalturk.amazonaws.com/AWSMechanicalTurkDataSchemas/2011-11-11/HTMLQuestion.xsd">
      <HTMLContent><![CDATA[
      Severity: Minor
      Found in lib/m_turk_utils.rb - About 3 hrs to fix

        Method update_template has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

          def update_template
    params[:evaluation] ||= {}

    if @evaluation.tasks.size > 0
      @fields = @evaluation.tasks.first.data.keys
        Severity: Minor
        Found in app/controllers/evaluations_controller.rb - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateChart has 81 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            updateChart: function() {
        // copy default options
        var options = $.extend(true, {}, TaskResponses.barChartOptions);

        // which question are we charting?
        Severity: Major
        Found in app/assets/javascripts/task_responses.js - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            , getContent: function () {
      var content
        , $e = this.$element
        , o = this.options
          Severity: Major
          Found in app/assets/javascripts/lib/bootstrap.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/lib/bootstrap.js on lines 1063..1072

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            , getTitle: function () {
      var title
        , $e = this.$element
        , o = this.options
          Severity: Major
          Found in app/assets/javascripts/lib/bootstrap.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/lib/bootstrap.js on lines 1182..1191

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _fnCollectionShow has 68 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              "_fnCollectionShow": function ()
    {
        var that = this, i, iLen;
        var oPos = $(this.dom.button).offset();
        var nHidden = this.dom.collection;
          Severity: Major
          Found in app/assets/javascripts/lib/ColVis.js - About 2 hrs to fix

            Method index has 65 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def index
    @eval = Evaluation.includes({
      :task_responses => {:mc_question_responses => [:mc_question_option], :fr_question_responses => [], :task => [], :m_turk_user => []},
      :fr_questions => [:fr_question_responses],
      :mc_questions => {:mc_question_options => [:mc_question_responses => [:mc_question_option]]}
            Severity: Major
            Found in app/controllers/task_responses_controller.rb - About 2 hrs to fix

              Method responses_csv has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                def responses_csv(sep = ',')
    CSV.generate(:col_sep => sep) do |csv|
      # Pull out the fields that were uploaded with the original data,
      # so that we can output these along with the task responses.
      orig_fields_keys = if @task_responses.empty?
              Severity: Minor
              Found in app/controllers/task_responses_controller.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method thread_pool has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                def Threading.thread_pool items, size=16, retry_count=3, &processor
    queue = Queue.new
    items.each {|o| queue.push o}
    threads = []
    results = []
              Severity: Minor
              Found in lib/threading.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( this.s.bShowAll )
        {
            nButton = this._fnDomShowAllButton();
            nButton.className += " ColVis_ShowAll";
            this.dom.buttons.push( nButton );
              Severity: Major
              Found in app/assets/javascripts/lib/ColVis.js and 1 other location - About 2 hrs to fix
              app/assets/javascripts/lib/ColVis.js on lines 467..473

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( this.s.bRestore )
        {
            nButton = this._fnDomRestoreButton();
            nButton.className += " ColVis_Restore";
            this.dom.buttons.push( nButton );
              Severity: Major
              Found in app/assets/javascripts/lib/ColVis.js and 1 other location - About 2 hrs to fix
              app/assets/javascripts/lib/ColVis.js on lines 475..481

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language