Sign upLogin

tylerhunt/remockable

View on GitHub
Star

Showing 15 of 15 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  include Remockable::ActiveModel::Helpers

  type :uniqueness

  valid_options %w(
Severity: Major
Found in lib/remockable/active_record/validate_uniqueness_of.rb and 2 other locations - About 1 hr to fix
lib/remockable/active_model/validate_exclusion_of.rb on lines 2..23
lib/remockable/active_model/validate_inclusion_of.rb on lines 2..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  include Remockable::ActiveModel::Helpers

  type :inclusion

  valid_options %w(allow_nil allow_blank if in message on unless)
Severity: Major
Found in lib/remockable/active_model/validate_inclusion_of.rb and 2 other locations - About 1 hr to fix
lib/remockable/active_model/validate_exclusion_of.rb on lines 2..23
lib/remockable/active_record/validate_uniqueness_of.rb on lines 4..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  include Remockable::ActiveModel::Helpers

  type :exclusion

  valid_options %w(allow_nil allow_blank if in message on unless)
Severity: Major
Found in lib/remockable/active_model/validate_exclusion_of.rb and 2 other locations - About 1 hr to fix
lib/remockable/active_model/validate_inclusion_of.rb on lines 2..23
lib/remockable/active_record/validate_uniqueness_of.rb on lines 4..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  include Remockable::ActiveModel::Helpers

  type :confirmation

  valid_options %w(if message on unless)
Severity: Major
Found in lib/remockable/active_model/validate_confirmation_of.rb and 2 other locations - About 1 hr to fix
lib/remockable/active_model/validate_presence_of.rb on lines 2..23
lib/remockable/active_record/validate_associated.rb on lines 2..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  include Remockable::ActiveModel::Helpers

  type :associated

  valid_options %w(if message on unless)
Severity: Major
Found in lib/remockable/active_record/validate_associated.rb and 2 other locations - About 1 hr to fix
lib/remockable/active_model/validate_confirmation_of.rb on lines 2..23
lib/remockable/active_model/validate_presence_of.rb on lines 2..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  include Remockable::ActiveModel::Helpers

  type :presence

  valid_options %w(if message on unless)
Severity: Major
Found in lib/remockable/active_model/validate_presence_of.rb and 2 other locations - About 1 hr to fix
lib/remockable/active_model/validate_confirmation_of.rb on lines 2..23
lib/remockable/active_record/validate_associated.rb on lines 2..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method method_missing has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def method_missing(method, *args, &block)
    unsupported_query_methods = %w(
      create_with
      eager_load
      includes
Severity: Minor
Found in lib/remockable/active_record/have_default_scope.rb - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              query_matches = scope.to_sql == relation.to_sql
          eager_load_matches = scope.eager_load_values == relation.eager_load_values
          includes_matches = scope.includes_values == relation.includes_values
          lock_matches = scope.lock_value == relation.lock_value
          preload_matches = scope.preload_values == relation.preload_values
    Severity: Major
    Found in lib/remockable/active_record/have_default_scope.rb and 1 other location - About 1 hr to fix
    lib/remockable/active_record/have_scope.rb on lines 19..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              query_matches = scope.to_sql == relation.to_sql
          eager_load_matches = scope.eager_load_values == relation.eager_load_values
          includes_matches = scope.includes_values == relation.includes_values
          lock_matches = scope.lock_value == relation.lock_value
          preload_matches = scope.preload_values == relation.preload_values
    Severity: Major
    Found in lib/remockable/active_record/have_scope.rb and 1 other location - About 1 hr to fix
    lib/remockable/active_record/have_default_scope.rb on lines 14..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Consider simplifying this complex logical expression.
    Open

            if relation
          query_matches = scope.to_sql == relation.to_sql
          eager_load_matches = scope.eager_load_values == relation.eager_load_values
          includes_matches = scope.includes_values == relation.includes_values
          lock_matches = scope.lock_value == relation.lock_value
    Severity: Major
    Found in lib/remockable/active_record/have_scope.rb - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

              if relation
          query_matches = scope.to_sql == relation.to_sql
          eager_load_matches = scope.eager_load_values == relation.eager_load_values
          includes_matches = scope.includes_values == relation.includes_values
          lock_matches = scope.lock_value == relation.lock_value
      Severity: Major
      Found in lib/remockable/active_record/have_default_scope.rb - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

            if index
      name_matches = name.nil? || matches_name?(index, name)
      unique_matches = unique.nil? || index.unique == unique
      where_matches = where.nil? || index.where == where
        Severity: Major
        Found in lib/remockable/active_record/have_index.rb - About 40 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            match do |actual|
    if association = subject.class.reflect_on_association(attribute)
      macro_matches = association.macro == :has_one
      options_match = association.options.slice(*options.keys) == options
      macro_matches && options_match
          Severity: Minor
          Found in lib/remockable/active_record/have_one.rb and 2 other locations - About 20 mins to fix
          lib/remockable/active_record/have_and_belong_to_many.rb on lines 13..18
          lib/remockable/active_record/have_many.rb on lines 19..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            match do |actual|
    if association = subject.class.reflect_on_association(attribute)
      macro_matches = association.macro == :has_and_belongs_to_many
      options_match = association.options.slice(*options.keys) == options
      macro_matches && options_match
          Severity: Minor
          Found in lib/remockable/active_record/have_and_belong_to_many.rb and 2 other locations - About 20 mins to fix
          lib/remockable/active_record/have_many.rb on lines 19..24
          lib/remockable/active_record/have_one.rb on lines 18..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            match do |actual|
    if association = subject.class.reflect_on_association(attribute)
      macro_matches = association.macro == :has_many
      options_match = association.options.slice(*options.keys) == options
      macro_matches && options_match
          Severity: Minor
          Found in lib/remockable/active_record/have_many.rb and 2 other locations - About 20 mins to fix
          lib/remockable/active_record/have_and_belong_to_many.rb on lines 13..18
          lib/remockable/active_record/have_one.rb on lines 18..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language