Sign upLogin

uktrade/directory-client-core

View on GitHub
Star

Showing 6 of 9 total issues

Function fallback has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

def fallback(cache):
    """
    Caches content retrieved by the client, thus allowing the cached
    content to be used later if the live content cannot be retrieved.
Severity: Minor
Found in directory_client_core/helpers.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function request has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def request(
Severity: Major
Found in directory_client_core/base.py - About 1 hr to fix

    Function wrapper has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def wrapper(client, url, params={}, *args, **kwargs):
    Severity: Minor
    Found in directory_client_core/helpers.py - About 35 mins to fix

      Function send has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def send(self, method, url, request=None, *args, **kwargs):
      Severity: Minor
      Found in directory_client_core/base.py - About 35 mins to fix

        Avoid too many return statements within this function.
        Open

                                return FailureResponse.from_response(response)
        Severity: Major
        Found in directory_client_core/helpers.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return LiveResponse.from_response(response)
          Severity: Major
          Found in directory_client_core/helpers.py - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language