Sign upLogin

unageanu/jiji2

View on GitHub
Star
sites/src/js/viewmodel/chart/pointer.js

Summary

Maintainability
C
7 hrs
Test Coverage

Pointer has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class Pointer extends Observable {

  constructor(coordinateCalculator, candleSticks, graphs) {
    super();
    this.coordinateCalculator = coordinateCalculator;
Severity: Minor
Found in sites/src/js/viewmodel/chart/pointer.js - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      constructor(coordinateCalculator, candleSticks, graphs) {
    super();
    this.coordinateCalculator = coordinateCalculator;
    this.candleSticks         = candleSticks;
    this.graphs               = graphs;
    Severity: Major
    Found in sites/src/js/viewmodel/chart/pointer.js and 2 other locations - About 1 hr to fix
    sites/src/js/viewmodel/chart/positions.js on lines 46..53
    sites/src/js/viewmodel/chart/slider.js on lines 9..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      set x(x) {
    this.setProperty("x", this.normalizeX(x));
    this.updateTime();
    this.updateRate();
    this.requestRefresh();
    Severity: Major
    Found in sites/src/js/viewmodel/chart/pointer.js and 1 other location - About 1 hr to fix
    sites/src/js/viewmodel/chart/pointer.js on lines 121..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      set y(y) {
    this.setProperty("y", this.normalizeY(y));
    this.updatePrice();
    this.updateBalance();
    this.requestRefresh();
    Severity: Major
    Found in sites/src/js/viewmodel/chart/pointer.js and 1 other location - About 1 hr to fix
    sites/src/js/viewmodel/chart/pointer.js on lines 112..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      unregisterObservers() {
    this.graphs.removeAllObservers(this);
    this.candleSticks.removeAllObservers(this);
    this.slider.removeAllObservers(this);
  }
    Severity: Major
    Found in sites/src/js/viewmodel/chart/pointer.js and 2 other locations - About 55 mins to fix
    sites/src/js/viewmodel/chart/graphs.js on lines 103..107
    sites/src/js/viewmodel/chart/slider.js on lines 42..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        this.graphs.addObserver("propertyChanged", (n, e) => {
      if (e.key === "lines") {
        this.updateBalance();
      }
    }, this);
    Severity: Minor
    Found in sites/src/js/viewmodel/chart/pointer.js and 1 other location - About 40 mins to fix
    sites/src/js/viewmodel/chart/graphs.js on lines 83..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
    Open

    import ContainerJS          from "container-js"
    Severity: Minor
    Found in sites/src/js/viewmodel/chart/pointer.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status