src/jiji/model/graphing/graph_factory.rb
Method create
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def create(label, type = :line, aggregation_type = :first,
colors = [], axises = [])
Use each_value
instead of values.each
. Open
Open
@graphs.values.each do |g|
- Read upRead up
- Exclude checks
This cop checks for uses of each_key
and each_value
Hash methods.
Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.
Example:
# bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }
# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }