unageanu/jiji2

View on GitHub
src/jiji/model/graphing/graph_factory.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def create(label, type = :line, aggregation_type = :first,
      colors = [], axises = [])
Severity: Minor
Found in src/jiji/model/graphing/graph_factory.rb - About 35 mins to fix

    Use each_value instead of values.each.
    Open

          @graphs.values.each do |g|

    This cop checks for uses of each_key and each_value Hash methods.

    Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

    Example:

    # bad
    hash.keys.each { |k| p k }
    hash.values.each { |v| p v }
    hash.each { |k, _v| p k }
    hash.each { |_k, v| p v }
    
    # good
    hash.each_key { |k| p k }
    hash.each_value { |v| p v }

    There are no issues that match your filters.

    Category
    Status