Sign upLogin

uruba/FinanCalc

View on GitHub
Star
src/Calculators/BondDurationCalculator.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

            $bondFaceValue,
            $bondAnnualCouponRate,
            $bondAnnualYield,
            $bondYearsToMaturity,
            $bondPaymentFrequency = 1
Severity: Minor
Found in src/Calculators/BondDurationCalculator.php - About 35 mins to fix

    The method getBondNominalCashFlows uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                    $nominalCashFlows[$i] = $couponPayment;
                }
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

                $i = 1;
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

                $i = 1;
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There must be one blank line after the last USE statement; 2 found;
    Open

        use FinanCalc\Utils\MathFuncs;
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpcodesniffer

    Multi-line function call not indented correctly; expected 20 spaces but found 24
    Open

                            $i++)
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpcodesniffer

    Closing parenthesis of a multi-line function call must be on a line by itself
    Open

                            $i++)
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpcodesniffer

    Closing parenthesis of a multi-line function call must be on a line by itself
    Open

                            $i++)
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpcodesniffer

    Multi-line function call not indented correctly; expected 20 spaces but found 24
    Open

                            $i++)
    Severity: Minor
    Found in src/Calculators/BondDurationCalculator.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status