Sign upLogin

uruba/FinanCalc

View on GitHub
Star
src/Calculators/Factories/BondDurationCalculatorFactory.php

Summary

Maintainability
C
1 day
Test Coverage

Method newCustomCouponFrequencyBond has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

            $bondFaceValue,
            $bondAnnualCouponRate,
            $bondAnnualYield,
            $bondYearsToMaturity,
            $bondPaymentFrequency
Severity: Minor
Found in src/Calculators/Factories/BondDurationCalculatorFactory.php - About 35 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    <?php

namespace FinanCalc\Calculators\Factories {

    use FinanCalc\Calculators\BondDurationCalculator;
    Severity: Major
    Found in src/Calculators/Factories/BondDurationCalculatorFactory.php and 2 other locations - About 1 day to fix
    src/Calculators/Factories/BondFairValueCalculatorFactory.php on lines 1..122
    src/Calculators/Factories/BondYTMCalculatorFactory.php on lines 1..143

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 245.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There must be one blank line after the last USE statement; 2 found;
    Open

        use FinanCalc\Interfaces\Calculator\CalculatorFactoryAbstract;
    Severity: Minor
    Found in src/Calculators/Factories/BondDurationCalculatorFactory.php by phpcodesniffer

    The closing brace for the class must go on the next line after the body
    Open

        }
    Severity: Minor
    Found in src/Calculators/Factories/BondDurationCalculatorFactory.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status