Sign upLogin

veksa/carrot-api

View on GitHub
Star

Showing 23 of 27 total issues

File Api.php has 593 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace Veksa\Carrot;

use Veksa\Carrot\Exceptions\Exception;
use Veksa\Carrot\Exceptions\HttpException;
Severity: Major
Found in src/Api.php - About 1 day to fix

    Conversation has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Conversation extends BaseType implements TypeInterface
{
    /**
     * {@inheritdoc}
     *
    Severity: Minor
    Found in src/Types/Conversation.php - About 4 hrs to fix

      Api has 31 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Api
{
    /**
     * HTTP codes
     *
      Severity: Minor
      Found in src/Api.php - About 3 hrs to fix

        Message has 25 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Message extends BaseType implements TypeInterface
{
    /**
     * {@inheritdoc}
     *
        Severity: Minor
        Found in src/Types/Message.php - About 2 hrs to fix

          File Conversation.php has 256 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
namespace Veksa\Carrot\Types;

use Veksa\Carrot\Exceptions\InvalidArgumentException;
          Severity: Minor
          Found in src/Types/Conversation.php - About 2 hrs to fix

            Method sendConversationMessage has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function sendConversationMessage(
        $id,
        $message,
        $type = 'note',
        $botName = 'Bot',
            Severity: Minor
            Found in src/Api.php - About 1 hr to fix

              Function getConversations has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getConversations(
        $userId = null,
        $limit = 20,
        $offset = 0,
        $closed = null,
              Severity: Minor
              Found in src/Api.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method sendConversationMessage has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $id,
        $message,
        $type = 'note',
        $botName = 'Bot',
        $fromUser = false,
              Severity: Major
              Found in src/Api.php - About 1 hr to fix

                Function sendConversationMessage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function sendConversationMessage(
        $id,
        $message,
        $type = 'note',
        $botName = 'Bot',
                Severity: Minor
                Found in src/Api.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function map has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function map($data)
    {
        foreach (static::$map as $key => $item) {
            if (isset($data[$key]) && (!is_array($data[$key]) || (is_array($data[$key]) && !empty($data[$key])))) {
                $method = 'set' . self::toCamelCase($key);
                Severity: Minor
                Found in src/Types/BaseType.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method addTag has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function addTag($id, $tag, $fromAdminId = null, $botName = 'Bot', $randomId = 0)
    {
        if ($this->isEmptyId($id)) {
            throw new InvalidArgumentException;
        }
                Severity: Minor
                Found in src/Api.php - About 1 hr to fix

                  Method deleteTag has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function deleteTag($id, $tag, $fromAdminId = null, $botName = 'Bot', $randomId = 0)
    {
        if ($this->isEmptyId($id)) {
            throw new InvalidArgumentException;
        }
                  Severity: Minor
                  Found in src/Api.php - About 1 hr to fix

                    Method getConversations has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            $userId = null,
        $limit = 20,
        $offset = 0,
        $closed = null,
        $assigned = null,
                    Severity: Minor
                    Found in src/Api.php - About 45 mins to fix

                      Method setTyping has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function setTyping($id, $message, $botName = null, $fromUser = false, $fromAdmin = 0)
                      Severity: Minor
                      Found in src/Api.php - About 35 mins to fix

                        Method assignConversation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function assignConversation($id, $adminId, $fromAdminId = null, $botName = 'Bot', $randomId = 0)
                        Severity: Minor
                        Found in src/Api.php - About 35 mins to fix

                          Method getLeads has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function getLeads($filters = [], $prop = '$last_seen', $order = 'desc', $limit = 20, $offset = 0)
                          Severity: Minor
                          Found in src/Api.php - About 35 mins to fix

                            Method addTag has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public function addTag($id, $tag, $fromAdminId = null, $botName = 'Bot', $randomId = 0)
                            Severity: Minor
                            Found in src/Api.php - About 35 mins to fix

                              Method deleteTag has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function deleteTag($id, $tag, $fromAdminId = null, $botName = 'Bot', $randomId = 0)
                              Severity: Minor
                              Found in src/Api.php - About 35 mins to fix

                                Function setProps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function setProps($id, $props, $isSystem = true)
    {
        if ($this->isEmptyString($id)) {
            throw new InvalidArgumentException;
        }
                                Severity: Minor
                                Found in src/Api.php - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function deleteProps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function deleteProps($id, $props, $isSystem = true)
    {
        if ($this->isEmptyString($id)) {
            throw new InvalidArgumentException;
        }
                                Severity: Minor
                                Found in src/Api.php - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language