vorteil/vorteil

View on GitHub

Showing 354 of 354 total issues

File ova-template.go has 786 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package xva

/**
 * SPDX-License-Identifier: Apache-2.0
 * Copyright 2020 vorteil.io Pty Ltd
Severity: Major
Found in pkg/xva/ova-template.go - About 1 day to fix

    Function Backends has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
    Open

    func Backends() ([]string, error) {
        var installedVirtualizers []string
        path := os.Getenv("PATH")
        separated := ":"
        if runtime.GOOS == "windows" {
    Severity: Minor
    Found in pkg/virtualizers/util.go - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Bundle.Reader has a Cognitive Complexity of 55 (exceeds 20 allowed). Consider refactoring.
    Open

    func (bundle *Bundle) Reader(tags ...string) io.ReadCloser {
    
        pr, pw := io.Pipe()
    
        go func(pw *io.PipeWriter) {
    Severity: Minor
    Found in pkg/vkern/bundle.go - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function run has a Cognitive Complexity of 51 (exceeds 20 allowed). Consider refactoring.
    Open

    func run(virt virtualizers.Virtualizer, diskpath string, cfg *vcfg.VCFG, name string) error {
    
        // Gather home directory for firecracker storage path
        home, err := homedir.Dir()
        if err != nil {
    Severity: Minor
    Found in pkg/cli/run.go - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File images.go has 624 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package cli
    
    /**
     * SPDX-License-Identifier: Apache-2.0
     * Copyright 2020 vorteil.io Pty Ltd
    Severity: Minor
    Found in pkg/cli/images.go - About 5 hrs to fix

      Method RemoteManager.get has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
      Open

      func (mgr *RemoteManager) get(version CalVer) error {
      
          Logger("Downloading kernel version: %s", version.String())
      
          kernelName := filenameFromVersion(version)
      Severity: Minor
      Found in pkg/vkern/manager-remote.go - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File virtualizer.go has 581 lines of code (exceeds 500 allowed). Consider refactoring.
      Open

      package virtualbox
      
      /**
       * SPDX-License-Identifier: Apache-2.0
       * Copyright 2020 vorteil.io Pty Ltd
      Severity: Minor
      Found in pkg/virtualizers/virtualbox/virtualizer.go - About 3 hrs to fix

        Method CLIRemoteManager.get has 115 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (mgr *CLIRemoteManager) get(version CalVer) error {
        
            prog := mgr.log.NewProgress(fmt.Sprintf("Fetching kernel: %s", version.String()), "", 0)
            defer prog.Finish(false)
        
        
        Severity: Major
        Found in pkg/vkern/cli.go - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (f *NStringFlag) AddTo(flagSet *pflag.FlagSet) {
              if f.Value == nil {
                  f.Value = make([]string, *f.Total, *f.Total)
              }
          
          
          Severity: Major
          Found in pkg/flag/string.go and 1 other location - About 3 hrs to fix
          pkg/flag/bool.go on lines 71..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 279.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (f *NBoolFlag) AddTo(flagSet *pflag.FlagSet) {
          
              if f.Value == nil {
                  f.Value = make([]bool, *f.Total, *f.Total)
              }
          Severity: Major
          Found in pkg/flag/bool.go and 1 other location - About 3 hrs to fix
          pkg/flag/string.go on lines 34..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 279.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function LookForIP has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
          Open

          func LookForIP(l *logger.Logger, routes []virtualizers.NetworkInterface) []virtualizers.NetworkInterface {
          
              sub := l.Subscribe()
              inbox := sub.Inbox()
              var msg string
          Severity: Minor
          Found in pkg/virtualizers/util/util.go - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (vcfg *VCFG) mergeNFS(b *VCFG) error {
              if vcfg.NFS == nil {
                  vcfg.NFS = b.NFS
              } else if b.NFS != nil {
          
          
          Severity: Major
          Found in pkg/vcfg/merge.go and 1 other location - About 2 hrs to fix
          pkg/vcfg/merge.go on lines 180..202

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 228.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (vcfg *VCFG) mergeRoutes(b *VCFG) error {
              if vcfg.Routing == nil {
                  vcfg.Routing = b.Routing
              } else if b.Routing != nil {
          
          
          Severity: Major
          Found in pkg/vcfg/merge.go and 1 other location - About 2 hrs to fix
          pkg/vcfg/merge.go on lines 204..227

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 228.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function run has 89 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func run(virt virtualizers.Virtualizer, diskpath string, cfg *vcfg.VCFG, name string) error {
          
              // Gather home directory for firecracker storage path
              home, err := homedir.Dir()
              if err != nil {
          Severity: Major
          Found in pkg/cli/run.go - About 2 hrs to fix

            Method StreamOptimizedWriter.flushGrain has 89 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (w *StreamOptimizedWriter) flushGrain() error {
                var err error
                defer func() {
                    w.grainNo++
                    w.cursor = w.grainNo * GrainSize
            Severity: Major
            Found in pkg/vmdk/stream-optimized.go - About 2 hrs to fix

              Function Backends has 86 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func Backends() ([]string, error) {
                  var installedVirtualizers []string
                  path := os.Getenv("PATH")
                  separated := ":"
                  if runtime.GOOS == "windows" {
              Severity: Major
              Found in pkg/virtualizers/util.go - About 2 hrs to fix

                Method Virtualizer.Start has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
                Open

                func (v *Virtualizer) Start() error {
                    v.logger.Debugf("Starting VM")
                    v.command = exec.Command(v.command.Args[0], v.command.Args[1:]...)
                    v.command.SysProcAttr = &syscall.SysProcAttr{
                        Setpgid: true,
                Severity: Minor
                Found in pkg/virtualizers/qemu/virtualizer_notwindows.go - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method StreamOptimizedWriter.flushGrain has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
                Open

                func (w *StreamOptimizedWriter) flushGrain() error {
                    var err error
                    defer func() {
                        w.grainNo++
                        w.cursor = w.grainNo * GrainSize
                Severity: Minor
                Found in pkg/vmdk/stream-optimized.go - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (f *NBoolFlag) AddUnhiddenTo(flagSet *pflag.FlagSet) {
                
                    if f.Value == nil {
                        f.Value = make([]bool, *f.Total, *f.Total)
                    }
                Severity: Major
                Found in pkg/flag/bool.go and 1 other location - About 2 hrs to fix
                pkg/flag/string.go on lines 58..73

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 215.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (f *NStringFlag) AddUnhiddenTo(flagSet *pflag.FlagSet) {
                
                    if f.Value == nil {
                        f.Value = make([]string, *f.Total, *f.Total)
                    }
                Severity: Major
                Found in pkg/flag/string.go and 1 other location - About 2 hrs to fix
                pkg/flag/bool.go on lines 101..116

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 215.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language