Showing 546 of 546 total issues
Function LookForIP
has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring. Open
func LookForIP(l *logger.Logger, routes []virtualizers.NetworkInterface) []virtualizers.NetworkInterface {
sub := l.Subscribe()
inbox := sub.Inbox()
var msg string
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method compiler.writeAllocGroup
has 34 return statements (exceeds 4 allowed). Open
func (c *compiler) writeAllocGroup(ctx context.Context, w io.WriteSeeker, ag int64) error {
var err error
allocGroupOffset := ag * c.blocksPerAllocGroup() * c.blockSize()
_, err = w.Seek(allocGroupOffset, io.SeekStart)
Function run
has 92 lines of code (exceeds 50 allowed). Consider refactoring. Open
func run(virt virtualizers.Virtualizer, diskpath string, cfg *vcfg.VCFG, name string) error {
// Gather home directory for firecracker storage path
home, err := homedir.Dir()
if err != nil {
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (vcfg *VCFG) mergeRoutes(b *VCFG) error {
if vcfg.Routing == nil {
vcfg.Routing = b.Routing
} else if b.Routing != nil {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 228.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (vcfg *VCFG) mergeNFS(b *VCFG) error {
if vcfg.NFS == nil {
vcfg.NFS = b.NFS
} else if b.NFS != nil {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 228.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method Provisioner.Provision
has 90 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
authHeader := fmt.Sprintf("Basic %s", base64.StdEncoding.EncodeToString([]byte(fmt.Sprintf("%s:%s", p.cfg.Username, p.cfg.Password))))
if args.Description != "" {
p.log.Warnf(`The 'description' field is ignored by Nutanix provision operation`)
Method Provisioner.Provision
has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring. Open
func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
var err error
// report that the 'description' flag is ignored if using this provisioner
if args.Description != "" {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method StreamOptimizedWriter.flushGrain
has 89 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (w *StreamOptimizedWriter) flushGrain() error {
var err error
defer func() {
w.grainNo++
w.cursor = w.grainNo * GrainSize
Function Backends
has 86 lines of code (exceeds 50 allowed). Consider refactoring. Open
func Backends() ([]string, error) {
var installedVirtualizers []string
path := os.Getenv("PATH")
separated := ":"
if runtime.GOOS == "windows" {
Method StreamOptimizedWriter.flushGrain
has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring. Open
func (w *StreamOptimizedWriter) flushGrain() error {
var err error
defer func() {
w.grainNo++
w.cursor = w.grainNo * GrainSize
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Virtualizer.Start
has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring. Open
func (v *Virtualizer) Start() error {
v.logger.Debugf("Starting VM")
v.command = exec.Command(v.command.Args[0], v.command.Args[1:]...)
v.command.SysProcAttr = &syscall.SysProcAttr{
Setpgid: true,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (f *NBoolFlag) AddUnhiddenTo(flagSet *pflag.FlagSet) {
if f.Value == nil {
f.Value = make([]bool, *f.Total, *f.Total)
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 215.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (f *NStringFlag) AddUnhiddenTo(flagSet *pflag.FlagSet) {
if f.Value == nil {
f.Value = make([]string, *f.Total, *f.Total)
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 215.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method SparseWriter.writeGrainData
has 82 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (w *SparseWriter) writeGrainData() error {
var err error
firstDataSector := int64(w.hdr.OverHead) * SectorsPerGrain
Function calculateMinimumSize
has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring. Open
func calculateMinimumSize(ctx context.Context, minDataBlocks, minInodes, minInodesPer64 int64) (int64, error) {
var err error
var journalBlocks, contentBlocks, groups, groupsPerFlex int64
var maxOverflowBlocks, inodesPerGroup, groupDescriptors int64
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function copyImageFileRecursive
has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring. Open
func copyImageFileRecursive(vorteilImage *vdecompiler.IO, ino int, rpath string, destFilePath string) error {
var f *os.File
var rdr io.Reader
var err error
var entries []*vdecompiler.DirectoryEntry
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function calculateMinimumSize
has 80 lines of code (exceeds 50 allowed). Consider refactoring. Open
func calculateMinimumSize(ctx context.Context, minDataBlocks, minInodes, minInodesPer64 int64) (int64, error) {
var err error
var journalBlocks, contentBlocks, groups, groupsPerFlex int64
var maxOverflowBlocks, inodesPerGroup, groupDescriptors int64
Method FixedWriter.writeFooter
has 78 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (w *FixedWriter) writeFooter() error {
var err error
_, err = w.Seek(0, io.SeekEnd)
if err != nil {
Method RemoteManager.get
has 78 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (mgr *RemoteManager) get(version CalVer) error {
Logger("Downloading kernel version: %s", version.String())
kernelName := filenameFromVersion(version)
Method Bundle.Reader
has 78 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (bundle *Bundle) Reader(tags ...string) io.ReadCloser {
pr, pw := io.Pipe()
go func(pw *io.PipeWriter) {