vorteil/vorteil

View on GitHub
pkg/cli/repositories.go

Summary

Maintainability
B
6 hrs
Test Coverage
F
1%

Function uploadPackage has 7 return statements (exceeds 4 allowed).
Open

func uploadPackage(url string, repo []string, token string, file *os.File) error {
    client := &http.Client{}

    stats, err := file.Stat()
    if err != nil {
Severity: Major
Found in pkg/cli/repositories.go - About 45 mins to fix

    Function pushPackage has 5 return statements (exceeds 4 allowed).
    Open

    func pushPackage(builder vpkg.Builder, url string, repo []string) error {
    
        // check authentication before doing things
        token, err := checkAuthentication()
        if err != nil {
    Severity: Major
    Found in pkg/cli/repositories.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          PreRunE: func(cmd *cobra.Command, args []string) error {
              if len(args) != 1 {
                  return errors.New("Must provide the name of the key you want to delete")
              }
              usr, err := os.UserHomeDir()
      Severity: Major
      Found in pkg/cli/repositories.go and 1 other location - About 1 hr to fix
      pkg/cli/repositories.go on lines 150..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 160.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          PreRunE: func(cmd *cobra.Command, args []string) error {
              if len(args) < 2 {
                  return errors.New("must provide a NAME and TOKEN")
              }
              usr, err := os.UserHomeDir()
      Severity: Major
      Found in pkg/cli/repositories.go and 1 other location - About 1 hr to fix
      pkg/cli/repositories.go on lines 324..341

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 160.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          PreRunE: func(cmd *cobra.Command, args []string) error {
              usr, err := os.UserHomeDir()
              if err != nil {
                  return err
              }
      Severity: Major
      Found in pkg/cli/repositories.go and 1 other location - About 1 hr to fix
      pkg/cli/repositories.go on lines 254..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 135.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          PreRunE: func(cmd *cobra.Command, args []string) error {
              usr, err := os.UserHomeDir()
              if err != nil {
                  return err
              }
      Severity: Major
      Found in pkg/cli/repositories.go and 1 other location - About 1 hr to fix
      pkg/cli/repositories.go on lines 48..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 135.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status