Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/imagetools/decompile.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function decompileImageRecursive has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func decompileImageRecursive(vorteilImage *vdecompiler.IO, report DecompileReport, symlinkCallbacks []func() error, ino int, rpath string, dpath string) (DecompileReport, []func() error, error) {
    var entries []*vdecompiler.DirectoryEntry

    inode, err := vorteilImage.ResolveInode(ino)
    if err != nil {
Severity: Minor
Found in pkg/imagetools/decompile.go - About 1 hr to fix

    Function decompileImageRecursive has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
    Open

    func decompileImageRecursive(vorteilImage *vdecompiler.IO, report DecompileReport, symlinkCallbacks []func() error, ino int, rpath string, dpath string) (DecompileReport, []func() error, error) {
    var entries []*vdecompiler.DirectoryEntry

    inode, err := vorteilImage.ResolveInode(ino)
    if err != nil {
    Severity: Minor
    Found in pkg/imagetools/decompile.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decompileImageRecursive has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func decompileImageRecursive(vorteilImage *vdecompiler.IO, report DecompileReport, symlinkCallbacks []func() error, ino int, rpath string, dpath string) (DecompileReport, []func() error, error) {
    Severity: Minor
    Found in pkg/imagetools/decompile.go - About 45 mins to fix

      Your code does not pass gofmt in 1 place. Go fmt your code!
      Open

      package imagetools
      Severity: Minor
      Found in pkg/imagetools/decompile.go by gofmt

      There are no issues that match your filters.

      Category
      Status