vorteil/vorteil

View on GitHub
pkg/provisioners/amazon/amazon.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method Provisioner.Provision has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
    var err error
    var imageID *string
    p.args = *args

Severity: Minor
Found in pkg/provisioners/amazon/amazon.go - About 1 hr to fix

    Method Provisioner.Validate has 8 return statements (exceeds 4 allowed).
    Open

    func (p *Provisioner) Validate() error {
        // Validate
        if p.cfg.Key == "" {
            return errors.New("no defined access key")
        }
    Severity: Major
    Found in pkg/provisioners/amazon/amazon.go - About 50 mins to fix

      Method Provisioner.Provision has 5 return statements (exceeds 4 allowed).
      Open

      func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
          var err error
          var imageID *string
          p.args = *args
      
      
      Severity: Major
      Found in pkg/provisioners/amazon/amazon.go - About 35 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
            p := new(Provisioner)
            p.cfg = cfg
            p.log = log
        
        
        Severity: Major
        Found in pkg/provisioners/amazon/amazon.go and 4 other locations - About 45 mins to fix
        pkg/provisioners/azure/azure.go on lines 62..72
        pkg/provisioners/google/google.go on lines 146..157
        pkg/provisioners/nutanix/nutanix.go on lines 37..47
        pkg/provisioners/vcenter/vcenter.go on lines 58..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package amazon
        Severity: Minor
        Found in pkg/provisioners/amazon/amazon.go by gofmt

        There are no issues that match your filters.

        Category
        Status