Sign upLogin

voucherifyio/voucherify-ruby-sdk

View on GitHub
Star

Showing 9 of 9 total issues

Class Client has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client
    attr_reader :backend_url

    def initialize (options)
      @options = options
Severity: Minor
Found in lib/voucherify/client.rb - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        class LoyaltyRewards
      attr_reader :client

      def initialize(client)
        @client = client
    Severity: Major
    Found in lib/voucherify/service/loyalties.rb and 1 other location - About 2 hrs to fix
    lib/voucherify/service/loyalties.rb on lines 46..71

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        class LoyaltyEarningRules
      attr_reader :client

      def initialize(client)
        @client = client
    Severity: Major
    Found in lib/voucherify/service/loyalties.rb and 1 other location - About 2 hrs to fix
    lib/voucherify/service/loyalties.rb on lines 75..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method calculate_price has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.calculate_price(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
    Severity: Minor
    Found in lib/voucherify/utils.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculate_discount has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.calculate_discount(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
    Severity: Minor
    Found in lib/voucherify/utils.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculate_price has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.calculate_price(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
    Severity: Minor
    Found in lib/voucherify/utils.rb - About 1 hr to fix

      Method calculate_discount has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.calculate_discount(base_price, voucher, unit_price = nil)
      e = 100.0

      if voucher[:gift]
        discount = [voucher[:gift][:balance] / e, base_price].min
      Severity: Minor
      Found in lib/voucherify/utils.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def delete(campaign_name, params = {})
        @client.delete("/campaigns/#{ERB::Util.url_encode(campaign_name)}", {:force => (!!(params['force'] || params[:force])).to_s})
        nil
        Severity: Minor
        Found in lib/voucherify/service/campaigns.rb and 1 other location - About 15 mins to fix
        lib/voucherify/service/vouchers.rb on lines 40..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def delete(code, params = {})
        @client.delete("/vouchers/#{ERB::Util.url_encode(code)}", {:force => (!!(params['force'] || params[:force])).to_s})
        nil
        Severity: Minor
        Found in lib/voucherify/service/vouchers.rb and 1 other location - About 15 mins to fix
        lib/voucherify/service/campaigns.rb on lines 20..22

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language