Sign upLogin

voxpupuli/vox-pupuli-tasks

View on GitHub
Star

Showing 7 of 7 total issues

Method queue_validation has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def queue_validation
    force = mergeable.nil? || status.nil? || status == 'pending'

    case saved_changes.stringify_keys.keys.sort
    when %w[eligible_for_merge_comment eligible_for_ci_comment].sort
Severity: Minor
Found in app/models/pull_request.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sync_label_colors_and_descriptions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def sync_label_colors_and_descriptions
    config_labels = VOXPUPULI_CONFIG['labels'].map do |label|
      Label.new(name: label['name'],
                color: label['color'],
                description: label['description'])
Severity: Minor
Found in app/models/repository.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_with_github has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.update_with_github(gh_pull_request)
    PullRequest.where(github_id: gh_pull_request['id']).first_or_initialize.tap do |pull_request|
      # get current status. GitHub API does not expose it as an atttribute of a PR
      # However, https://github.com/search does
      repo_id = gh_pull_request['base']['repo']['id']
Severity: Minor
Found in app/models/pull_request.rb - About 1 hr to fix

    Method update_with_travis_payload has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.update_with_travis_payload(payload)
    Travis.where(travis_id: payload['id']).first_or_initialize.tap do |travis|
      travis.type                = payload['type']
      travis.state               = payload['state']
      travis.status              = payload['status']
    Severity: Minor
    Found in app/models/travis.rb - About 1 hr to fix

      Method update_with_github has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.update_with_github(gh_pull_request)
    PullRequest.where(github_id: gh_pull_request['id']).first_or_initialize.tap do |pull_request|
      # get current status. GitHub API does not expose it as an atttribute of a PR
      # However, https://github.com/search does
      repo_id = gh_pull_request['base']['repo']['id']
      Severity: Minor
      Found in app/models/pull_request.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def add_ci_comment
    return if repository.vpt_config.dig('comment_on', 'tests_failed') == false
    return unless eligible_for_ci_comment

    add_comment(I18n.t('comment.tests_fail', author: author))
      Severity: Minor
      Found in app/models/pull_request.rb and 1 other location - About 15 mins to fix
      app/models/pull_request.rb on lines 130..135

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def add_merge_comment
    return if repository.vpt_config.dig('comment_on', 'needs_rebase') == false
    return unless eligible_for_merge_comment

    add_comment(I18n.t('comment.needs_rebase', author: author))
      Severity: Minor
      Found in app/models/pull_request.rb and 1 other location - About 15 mins to fix
      app/models/pull_request.rb on lines 142..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language