Sign upLogin

webcomics/dosage

View on GitHub
Star
dosagelib/util.py

Summary

Maintainability
C
1 day
Test Coverage
D
60%

File util.py has 384 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# SPDX-License-Identifier: MIT
# Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
# Copyright (C) 2012-2014 Bastian Kleineidam
# Copyright (C) 2015-2020 Tobias Gruetzmacher
import html
Severity: Minor
Found in dosagelib/util.py - About 5 hrs to fix

    Cyclomatic complexity is too high in function strsize. (8)
    Open

    def strsize(b):
    """Return human representation of bytes b. A negative number of bytes
    raises a value error."""
    if b < 0:
        raise ValueError("Invalid negative byte number")
    Severity: Minor
    Found in dosagelib/util.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function tagre has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def tagre(tag, attribute, value, quote='"', before="", after=""):
    Severity: Minor
    Found in dosagelib/util.py - About 45 mins to fix

      Function urlopen has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def urlopen(url, session, referrer=None, max_content_bytes=None,
      Severity: Minor
      Found in dosagelib/util.py - About 45 mins to fix

        Function strsize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def strsize(b):
    """Return human representation of bytes b. A negative number of bytes
    raises a value error."""
    if b < 0:
        raise ValueError("Invalid negative byte number")
        Severity: Minor
        Found in dosagelib/util.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                return "%.1fMB" % (float(b) / (1024 * 1024))
        Severity: Major
        Found in dosagelib/util.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return "%.2fGB" % (float(b) / (1024 * 1024 * 1024))
          Severity: Major
          Found in dosagelib/util.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return "%.1fGB" % (float(b) / (1024 * 1024 * 1024))
            Severity: Major
            Found in dosagelib/util.py - About 30 mins to fix

              XXX found
              Open

                  # XXX: brutal hack
              Severity: Minor
              Found in dosagelib/util.py by fixme

              There are no issues that match your filters.

              Category
              Status