webcomics/dosage

View on GitHub

Showing 83 of 197 total issues

Function get_tagged_scraper_name has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def get_tagged_scraper_name(scraperobj, limit=None, reasons=None):
    """Get comic scraper name."""
    tags = []
    if scraperobj.adult:
        tags.append(TAG_ADULT)
Severity: Minor
Found in dosagelib/cmd.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function urlopen has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def urlopen(url, session, referrer=None, max_content_bytes=None,
Severity: Minor
Found in dosagelib/util.py - About 45 mins to fix

    Function fetchText has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def fetchText(self, url, data, textSearch, optional):
            """Search text entry for given text XPath in a HTML page."""
            if not textSearch:
                return None
            text = []
    Severity: Minor
    Found in dosagelib/scraper.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if 'paprika' in pageUrl and '69-2' in pageUrl:
                filename = filename.replace('69', '69-2')
            elif 'rascals' in pageUrl and '89-2' in pageUrl:
                filename = filename.replace('89', '90')
            elif 'rascals' in pageUrl and '133-2' in pageUrl:
    Severity: Major
    Found in dosagelib/plugins/kemonocafe.py - About 40 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, scraper, url, referrer, filename, text=None):
      Severity: Minor
      Found in dosagelib/comic.py - About 35 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, name, sub, last=None, adult=False, path='d/%s.html'):
        Severity: Minor
        Found in dosagelib/plugins/keenspot.py - About 35 mins to fix

          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, name, sub=None, last=None, baseUrl=None, lang=None):
          Severity: Minor
          Found in dosagelib/plugins/comicgenesis.py - About 35 mins to fix

            Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(self, name, path, first, sid, eol=False):
            Severity: Minor
            Found in dosagelib/plugins/shivaestudios.py - About 35 mins to fix

              Function addItem has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def addItem(self, title, link, description, date, append=True):
              Severity: Minor
              Found in dosagelib/rss.py - About 35 mins to fix

                Function write_entry has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def write_entry(self, fp, name, entry, min_comics, indent):
                Severity: Minor
                Found in scripts/scriptutil.py - About 35 mins to fix

                  Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def __init__(self, name, path, first, sid, eol=False):
                  Severity: Minor
                  Found in dosagelib/plugins/shivaestudios.py - About 35 mins to fix

                    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def __init__(self, name, sub, first, last=None, adult=False):
                    Severity: Minor
                    Found in dosagelib/plugins/kemonocafe.py - About 35 mins to fix

                      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def __init__(self, name, sub, prev, first, last=None):
                      Severity: Minor
                      Found in dosagelib/plugins/rhjunior.py - About 35 mins to fix

                        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def __init__(self, title, link, description, lang='en-us', encoding="utf-8"):
                        Severity: Minor
                        Found in dosagelib/rss.py - About 35 mins to fix

                          Function connect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def connect(self, lastchange=None):
                                  """Connect to host and get meta information."""
                                  headers = {}
                                  if lastchange:
                                      headers['If-Modified-Since'] = lastchange.strftime(RFC_1123_DT_STR)
                          Severity: Minor
                          Found in dosagelib/comic.py - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function fetchText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def fetchText(self, url, data, textSearch, optional):
                                  """Search text entry for given text pattern in a HTML page."""
                                  if textSearch:
                                      match = textSearch.search(data[0])
                                      if match:
                          Severity: Minor
                          Found in dosagelib/scraper.py - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function getIndexStripUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def getIndexStripUrl(self, index):
                                  (volume, strip) = index.split('-', maxsplit=1)
                                  try:
                                      pageNr = int(strip)
                                  except ValueError:
                          Severity: Minor
                          Found in dosagelib/plugins/b.py - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def save(self, basepath):
                                  """Save comic URL to filename on disk."""
                                  fnbase = self._fnbase(basepath)
                                  exist = [x for x in glob.glob(fnbase + ".*") if not x.endswith(".txt")]
                                  out.info(u"Get image URL %s" % self.url, level=1)
                          Severity: Minor
                          Found in dosagelib/comic.py - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function namer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def namer(self, imageUrl, pageUrl):
                                  filename = imageUrl.rsplit('/', 1)[-1].split('.', 1)[0]
                                  ext = imageUrl.rsplit('.', 1)[-1]
                                  if filename == 'j':
                                      filename = 'RF_E3_P52'
                          Severity: Minor
                          Found in dosagelib/plugins/r.py - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function strsize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def strsize(b):
                              """Return human representation of bytes b. A negative number of bytes
                              raises a value error."""
                              if b < 0:
                                  raise ValueError("Invalid negative byte number")
                          Severity: Minor
                          Found in dosagelib/util.py - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language