Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/filerepo/file/LocalFile.php

Summary

Maintainability
F
2 wks
Test Coverage

File LocalFile.php has 1498 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Major
Found in includes/filerepo/file/LocalFile.php - About 3 days to fix

    Method recordUpload3 has 280 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function recordUpload3(
        string $oldver,
        string $comment,
        string $pageText,
        Authority $performer,
    Severity: Major
    Found in includes/filerepo/file/LocalFile.php - About 1 day to fix

      LocalFile has 71 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class LocalFile extends File {
    private const VERSION = 13; // cache version

    private const CACHE_FIELD_MAX_LEN = 1000;
      Severity: Major
      Found in includes/filerepo/file/LocalFile.php - About 1 day to fix

        Function recordUpload3 has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

            public function recordUpload3(
        string $oldver,
        string $comment,
        string $pageText,
        Authority $performer,
        Severity: Minor
        Found in includes/filerepo/file/LocalFile.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function maybeUpgradeRow has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            public function maybeUpgradeRow() {
        if ( MediaWikiServices::getInstance()->getReadOnlyMode()->isReadOnly() || $this->upgrading ) {
            return;
        }
        Severity: Minor
        Found in includes/filerepo/file/LocalFile.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function upload has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function upload( $src, $comment, $pageText, $flags = 0, $props = false,
        $timestamp = false, Authority $uploader = null, $tags = [],
        $createNullRevision = true, $revert = false
    ) {
        if ( $this->getRepo()->getReadOnlyReason() !== false ) {
        Severity: Minor
        Found in includes/filerepo/file/LocalFile.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method loadFromCache has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function loadFromCache() {
        $this->dataLoaded = false;
        $this->extraDataLoaded = false;

        $key = $this->getCacheKey();
        Severity: Major
        Found in includes/filerepo/file/LocalFile.php - About 2 hrs to fix

          Method upload has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function upload( $src, $comment, $pageText, $flags = 0, $props = false,
        $timestamp = false, Authority $uploader = null, $tags = [],
        $createNullRevision = true, $revert = false
    ) {
        if ( $this->getRepo()->getReadOnlyReason() !== false ) {
          Severity: Major
          Found in includes/filerepo/file/LocalFile.php - About 2 hrs to fix

            Method loadFromRow has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function loadFromRow( $row, $prefix = 'img_' ) {
        $this->dataLoaded = true;

        $unprefixed = $this->unprefixRow( $row, $prefix );
            Severity: Major
            Found in includes/filerepo/file/LocalFile.php - About 2 hrs to fix

              Function setProps has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function setProps( $info ) {
        $this->dataLoaded = true;
        $fields = $this->getCacheFields( '' );
        $fields[] = 'fileExists';
              Severity: Minor
              Found in includes/filerepo/file/LocalFile.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function loadMetadataFromString has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function loadMetadataFromString( $metadataString ) {
        $this->extraDataLoaded = true;
        $this->metadataArray = [];
        $this->metadataBlobs = [];
        $this->unloadedMetadataBlobs = [];
              Severity: Minor
              Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method maybeUpgradeRow has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function maybeUpgradeRow() {
        if ( MediaWikiServices::getInstance()->getReadOnlyMode()->isReadOnly() || $this->upgrading ) {
            return;
        }
              Severity: Minor
              Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                Method setProps has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function setProps( $info ) {
        $this->dataLoaded = true;
        $fields = $this->getCacheFields( '' );
        $fields[] = 'fileExists';
                Severity: Minor
                Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                  Method publishTo has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function publishTo( $src, $dstRel, $flags = 0, array $options = [] ) {
        $srcPath = ( $src instanceof FSFile ) ? $src->getPath() : $src;

        $repo = $this->getRepo();
        if ( $repo->getReadOnlyReason() !== false ) {
                  Severity: Minor
                  Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                    Function publishTo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function publishTo( $src, $dstRel, $flags = 0, array $options = [] ) {
        $srcPath = ( $src instanceof FSFile ) ? $src->getPath() : $src;

        $repo = $this->getRepo();
        if ( $repo->getReadOnlyReason() !== false ) {
                    Severity: Minor
                    Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method move has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function move( $target ) {
        $localRepo = MediaWikiServices::getInstance()->getRepoGroup()->getLocalRepo();
        if ( $this->getRepo()->getReadOnlyReason() !== false ) {
            return $this->readOnlyFatalStatus();
        }
                    Severity: Minor
                    Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                      Method getHistory has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function getHistory( $limit = null, $start = null, $end = null, $inc = true ) {
        if ( !$this->exists() ) {
            return []; // Avoid hard failure when the file does not exist. T221812
        }
                      Severity: Minor
                      Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                        Method loadMetadataFromString has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function loadMetadataFromString( $metadataString ) {
        $this->extraDataLoaded = true;
        $this->metadataArray = [];
        $this->metadataBlobs = [];
        $this->unloadedMetadataBlobs = [];
                        Severity: Minor
                        Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                          Method upload has 10 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function upload( $src, $comment, $pageText, $flags = 0, $props = false,
        $timestamp = false, Authority $uploader = null, $tags = [],
        $createNullRevision = true, $revert = false
                          Severity: Major
                          Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                            Method deleteFile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function deleteFile( $reason, UserIdentity $user, $suppress = false ) {
        if ( $this->getRepo()->getReadOnlyReason() !== false ) {
            return $this->readOnlyFatalStatus();
        }
                            Severity: Minor
                            Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                              Method recordUpload3 has 9 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      string $oldver,
        string $comment,
        string $pageText,
        Authority $performer,
        $props = false,
                              Severity: Major
                              Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                                Method upgradeRow has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public function upgradeRow() {
        $dbw = $this->repo->getPrimaryDB();

        // Make a DB query condition that will fail to match the image row if the
        // image was reuploaded while the upgrade was in process.
                                Severity: Minor
                                Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                                  Function getMetadataItems has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function getMetadataItems( array $itemNames ): array {
        $this->load( self::LOAD_ALL );
        $result = [];
        $addresses = [];
        foreach ( $itemNames as $itemName ) {
                                  Severity: Minor
                                  Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Method prerenderThumbnails has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      public function prerenderThumbnails() {
        $uploadThumbnailRenderMap = MediaWikiServices::getInstance()
            ->getMainConfig()->get( MainConfigNames::UploadThumbnailRenderMap );

        $jobs = [];
                                  Severity: Minor
                                  Found in includes/filerepo/file/LocalFile.php - About 1 hr to fix

                                    Function getHeight has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function getHeight( $page = 1 ) {
        $page = (int)$page;
        if ( $page < 1 ) {
            $page = 1;
        }
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 45 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function getWidth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function getWidth( $page = 1 ) {
        $page = (int)$page;
        if ( $page < 1 ) {
            $page = 1;
        }
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 45 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function loadFromRow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function loadFromRow( $row, $prefix = 'img_' ) {
        $this->dataLoaded = true;

        $unprefixed = $this->unprefixRow( $row, $prefix );
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 35 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function getHistory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function getHistory( $limit = null, $start = null, $end = null, $inc = true ) {
        if ( !$this->exists() ) {
            return []; // Avoid hard failure when the file does not exist. T221812
        }
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 35 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function purgeThumbList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        protected function purgeThumbList( $dir, $files ) {
        $fileListDebug = strtr(
            var_export( $files, true ),
            [ "\n" => '' ]
        );
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function loadExtraFromDB has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        protected function loadExtraFromDB() {
        if ( !$this->title ) {
            return; // Avoid hard failure when the file does not exist. T221812
        }
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function getThumbnails has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        protected function getThumbnails( $archiveName = false ) {
        if ( $archiveName ) {
            $dir = $this->getArchiveThumbPath( $archiveName );
        } else {
            $dir = $this->getThumbPath();
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function load( $flags = 0 ) {
        if ( !$this->dataLoaded ) {
            if ( $flags & IDBAccessObject::READ_LATEST ) {
                $this->loadFromDB( $flags );
            } else {
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function prerenderThumbnails has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function prerenderThumbnails() {
        $uploadThumbnailRenderMap = MediaWikiServices::getInstance()
            ->getMainConfig()->get( MainConfigNames::UploadThumbnailRenderMap );

        $jobs = [];
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                        protected function loadMetadataFromString( $metadataString ) {
        $this->extraDataLoaded = true;
        $this->metadataArray = [];
        $this->metadataBlobs = [];
        $this->unloadedMetadataBlobs = [];
                                    Severity: Major
                                    Found in includes/filerepo/file/LocalFile.php and 1 other location - About 1 day to fix
                                    includes/filerepo/file/ArchivedFile.php on lines 559..596

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 294.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                        public static function newFromKey( $sha1, $repo, $timestamp = false ) {
        $dbr = $repo->getReplicaDB();
        $queryBuilder = FileSelectQueryBuilder::newForFile( $dbr );

        $queryBuilder->where( [ 'img_sha1' => $sha1 ] );
                                    Severity: Major
                                    Found in includes/filerepo/file/LocalFile.php and 1 other location - About 2 hrs to fix
                                    includes/filerepo/file/OldLocalFile.php on lines 101..116

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 129.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                        public function getHeight( $page = 1 ) {
        $page = (int)$page;
        if ( $page < 1 ) {
            $page = 1;
        }
                                    Severity: Major
                                    Found in includes/filerepo/file/LocalFile.php and 1 other location - About 1 hr to fix
                                    includes/filerepo/file/LocalFile.php on lines 911..935

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 111.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                        public function getWidth( $page = 1 ) {
        $page = (int)$page;
        if ( $page < 1 ) {
            $page = 1;
        }
                                    Severity: Major
                                    Found in includes/filerepo/file/LocalFile.php and 1 other location - About 1 hr to fix
                                    includes/filerepo/file/LocalFile.php on lines 944..968

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 111.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                        public function getUploader( int $audience = self::FOR_PUBLIC, Authority $performer = null ): ?UserIdentity {
        $this->load();
        if ( $audience === self::FOR_PUBLIC && $this->isDeleted( self::DELETED_USER ) ) {
            return null;
        } elseif ( $audience === self::FOR_THIS_USER && !$this->userCan( self::DELETED_USER, $performer ) ) {
                                    Severity: Major
                                    Found in includes/filerepo/file/LocalFile.php and 1 other location - About 1 hr to fix
                                    includes/filerepo/file/ArchivedFile.php on lines 706..715

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 110.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            if ( $addresses ) {
            $resultFromBlob = $this->metadataStorageHelper->getMetadataFromBlobStore( $addresses );
            foreach ( $addresses as $itemName => $address ) {
                unset( $this->unloadedMetadataBlobs[$itemName] );
                $value = $resultFromBlob[$itemName] ?? null;
                                    Severity: Minor
                                    Found in includes/filerepo/file/LocalFile.php and 1 other location - About 30 mins to fix
                                    includes/filerepo/file/ArchivedFile.php on lines 475..485

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 91.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    There are no issues that match your filters.

                                    Category
                                    Status