Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/parser/Preprocessor_Hash.php

Summary

Maintainability
F
1 wk
Test Coverage

Function buildDomTreeArrayFromText has a Cognitive Complexity of 300 (exceeds 5 allowed). Consider refactoring.
Open

    private function buildDomTreeArrayFromText( $text, $flags ) {
        $forInclusion = ( $flags & self::DOM_FOR_INCLUSION );
        $langConversionDisabled = ( $flags & self::DOM_LANG_CONVERSION_DISABLED );

        $xmlishElements = $this->parser->getStripList();
Severity: Minor
Found in includes/parser/Preprocessor_Hash.php - About 6 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildDomTreeArrayFromText has 523 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildDomTreeArrayFromText( $text, $flags ) {
        $forInclusion = ( $flags & self::DOM_FOR_INCLUSION );
        $langConversionDisabled = ( $flags & self::DOM_LANG_CONVERSION_DISABLED );

        $xmlishElements = $this->parser->getStripList();
Severity: Major
Found in includes/parser/Preprocessor_Hash.php - About 2 days to fix

    File Preprocessor_Hash.php has 599 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Preprocessor using PHP arrays
 *
 * This program is free software; you can redistribute it and/or modify
    Severity: Major
    Found in includes/parser/Preprocessor_Hash.php - About 1 day to fix

      Avoid deeply nested control flow statements.
      Open

                                  if ( $c === false ) {
                                break;
                            }
      Severity: Major
      Found in includes/parser/Preprocessor_Hash.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if ( $part->commentEnd !== $wsStart - 1 ) {
                                $part->visualEnd = $wsStart;
                            }
        Severity: Major
        Found in includes/parser/Preprocessor_Hash.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status