Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
maintenance/CheckIndexes.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function execute has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        if ( $this->hasOption( 'nagios' ) ) {
            // Force silent running mode so we can match Nagios expected output.
            $this->mQuiet = true;
        }
Severity: Minor
Found in maintenance/CheckIndexes.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        if ( $this->hasOption( 'nagios' ) ) {
            // Force silent running mode so we can match Nagios expected output.
            $this->mQuiet = true;
        }
Severity: Minor
Found in maintenance/CheckIndexes.php - About 1 hr to fix

    Function printErrorRecursive has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function printErrorRecursive( $indent, array $array ) {
        foreach ( $array as $key => $value ) {
            $line = $indent;
            if ( !is_numeric( $key ) ) {
                $line .= "$key...";
    Severity: Minor
    Found in maintenance/CheckIndexes.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function check( $name, $expected, $actual ) {
        $this->output( str_repeat( "\t", count( $this->path ) ) );
        $this->output( "$name..." );
        if ( is_array( $expected ) ) {
            if ( in_array( $actual, $expected ) ) {
    Severity: Minor
    Found in maintenance/CheckIndexes.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status