Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
messagegroups/AggregateMessageGroup.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function getGroups has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function getGroups(): array {
        if ( $this->groups === null ) {
            $groups = [];
            $ids = (array)$this->conf['GROUPS'];
            $ids = MessageGroups::expandWildcards( $ids );
Severity: Minor
Found in messagegroups/AggregateMessageGroup.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadMessagesFromCache has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function loadMessagesFromCache( $groups ) {
        $messages = [];
        foreach ( $groups as $group ) {
            if ( $group instanceof self ) {
                $messages += $this->loadMessagesFromCache( $group->getGroups() );
Severity: Minor
Found in messagegroups/AggregateMessageGroup.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status