wikimedia/mediawiki-extensions-UniversalLanguageSelector

View on GitHub
lib/jquery.uls/src/jquery.uls.lcd.js

Summary

Maintainability
D
1 day
Test Coverage

File jquery.uls.lcd.js has 376 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Universal Language Selector
 * Language category display component - Used for showing the search results,
 * grouped by regions, scripts
 *
Severity: Minor
Found in lib/jquery.uls/src/jquery.uls.lcd.js - About 5 hrs to fix

    Function renderRegion has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            renderRegion: function ( $region, languages, itemsPerColumn, columnsPerRow ) {
                var columnsClasses, i, lastItem, currentScript, nextScript, force,
                    languagesCount = languages.length,
                    items = [],
                    columns = [],
    Severity: Minor
    Found in lib/jquery.uls/src/jquery.uls.lcd.js - About 1 hr to fix

      Function render has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              render: function () {
                  var $section,
                      $quicklist = this.buildQuicklist(),
                      regions = [],
                      regionNames = {
      Severity: Minor
      Found in lib/jquery.uls/src/jquery.uls.lcd.js - About 1 hr to fix

        Function buildQuicklist has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                buildQuicklist: function () {
                    var quickList, $quickListSection, $quickListSectionTitle;
        
                    if ( this.$cachedQuicklist !== null ) {
                        return this.$cachedQuicklist;
        Severity: Minor
        Found in lib/jquery.uls/src/jquery.uls.lcd.js - About 1 hr to fix

          Function append has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  append: function ( langCode, regionCode ) {
                      var i, regions;
          
                      if ( !$.uls.data.languages[ langCode ] ) {
                          // Language is unknown or not in the list of languages for this context.
          Severity: Minor
          Found in lib/jquery.uls/src/jquery.uls.lcd.js - About 1 hr to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                $.fn.lcd = function ( option ) {
                    return this.each( function () {
                        var $this = $( this ),
                            data = $this.data( 'lcd' ),
                            options = typeof option === 'object' && option;
            Severity: Major
            Found in lib/jquery.uls/src/jquery.uls.lcd.js and 3 other locations - About 4 hrs to fix
            lib/jquery.uls/src/jquery.uls.languagefilter.js on lines 347..361
            lib/jquery.webfonts/src/jquery.webfonts.js on lines 472..486
            resources/js/ext.uls.languagesettings.js on lines 301..315

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status