wikimedia/mediawiki-extensions-VisualEditor

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    this.heightsInput = new OO.ui.NumberInputWidget( {
        min: 0,
        showButtons: false,
        input: {
            placeholder: ve.msg( 'visualeditor-mwgallerydialog-heights-input-placeholder', this.defaults.imageHeight )

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

ve.dm.MWGalleryNode.static.getHashObject = function ( dataElement ) {
    return {
        type: dataElement.type,
        mw: ve.copy( dataElement.attributes.mw )
    };

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

        if (
            pageCanLoadEditor &&
            showWikitextWelcome &&
            // At least one editor is available (T201928)
            ( init.isVisualAvailable || init.isWikitextAvailable || $( '#wpTextbox1' ).length ) &&

Function onWindowPopState has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.init.mw.DesktopArticleTarget.prototype.onWindowPopState = function ( e ) {
    if ( !this.verifyPopState( e.state ) ) {
        // Ignore popstate events fired for states not created by us
        // This also filters out the initial fire in Chrome (T59901).
        return;

Function preparedCacheKeyPromise has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        .then( ( deflatedHtml ) => {
            if ( aborted ) {
                return ve.createDeferred().reject();
            }
            xhr = this.getContentApi().postWithToken( 'csrf',

Function parseDocument has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.init.mw.Target.static.parseDocument = function ( documentString, mode, section, onlySection ) {
    let doc;
    if ( mode === 'source' ) {
        // Parent method
        doc = ve.init.mw.Target.super.static.parseDocument.call( this, documentString, mode );

Function onHighlightItem has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.ui.MWGalleryDialog.prototype.onHighlightItem = function ( item ) {
    // Unhighlight previous item
    if ( this.highlightedItem ) {
        this.highlightedItem.toggleHighlighted( false );
    }

Function updateImageNode has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.dm.MWImageModel.prototype.updateImageNode = function ( node, surfaceModel ) {
    const doc = surfaceModel.getDocument();

    // Update the caption
    if ( node.getType() === 'mwBlockImage' ) {

Function VeUiMWGalleryItemWidget has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.ui.MWGalleryItemWidget = function VeUiMWGalleryItemWidget( imageInfo, config ) {
    this.resource = imageInfo.resource;
    this.altText = imageInfo.altText || '';
    this.altTextSame = imageInfo.altTextSame;
    this.href = imageInfo.href;

Function onCopy has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.ce.MWWikitextSurface.prototype.onCopy = function ( e ) {
    const clipboardData = e.originalEvent.clipboardData,
        text = this.getModel().getFragment().getText( true ).replace( /\n\n/g, '\n' );

    if ( !text ) {

Function VeCeMWInlineImageNode has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.ce.MWInlineImageNode = function VeCeMWInlineImageNode( model, config ) {
    let $image;
    let hasHref = false;

    if ( model.getAttribute( 'isError' ) ) {

Method onCustomEditor has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function onCustomEditor( $article, $user ) {
        $req = $article->getContext()->getRequest();
        $services = MediaWikiServices::getInstance();
        $urlUtils = $services->getUrlUtils();
        $veConfig = $services->getConfigFactory()->makeConfig( 'visualeditor' );

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    for ( const key in params ) {
        $form.append( $( '<input>' ).attr( { type: 'hidden', name: key, value: params[ key ] } ) );
    }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

ve.init.mw.GalleryImageInfoCache = function VeInitMwGalleryImageInfoCache() {
    // Parent constructor
    ve.init.mw.GalleryImageInfoCache.super.apply( this, arguments );
};

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

ve.init.mw.ImageInfoCache = function VeInitMwImageInfoCache() {
    // Parent constructor
    ve.init.mw.ImageInfoCache.super.apply( this, arguments );
};

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

ve.init.mw.LinkCache = function VeInitMwLinkCache() {
    // Parent constructor
    ve.init.mw.LinkCache.super.apply( this, arguments );
};

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

ve.dm.MWNoContentConvertMetaItem.static.toDataElement = function ( domElements ) {
    // HACK: Don't rely on Parsoid always putting the RDFa type as a property
    return {
        type: this.name,
        originalProperty: domElements[ 0 ].getAttribute( 'property' )

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

ve.dm.MWNoTitleConvertMetaItem.static.toDataElement = function ( domElements ) {
    // HACK: Don't rely on Parsoid always putting the RDFa type as a property
    return {
        type: this.name,
        originalProperty: domElements[ 0 ].getAttribute( 'property' )

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    for ( const key in params ) {
        $form.append( $( '<input>' ).attr( { type: 'hidden', name: key, value: params[ key ] } ) );
    }

• Read up
  Read up

Function getSetupProcess has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

ve.ui.MWMediaDialog.prototype.getSetupProcess = function ( data ) {
    return ve.ui.MWMediaDialog.super.prototype.getSetupProcess.call( this, data )
        .next( () => {
            const isReadOnly = this.isReadOnly();