wikimedia/mediawiki-extensions-VisualEditor

View on GitHub

Showing 912 of 912 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ve.ui.MWTransclusionDialog.prototype.addTemplatePlaceholder = function () {
    this.addPart( new ve.dm.MWTemplatePlaceholderModel( this.transclusionModel ) );
};
Severity: Major
Found in modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js and 1 other location - About 1 hr to fix
modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js on lines 134..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.typeFieldset = new OO.ui.FieldsetLayout( {
        $overlay: this.$overlay,
        label: ve.msg( 'visualeditor-dialog-media-type-section' ),
        help: ve.msg( 'visualeditor-dialog-media-type-section-help' )
    } );
Severity: Major
Found in modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js and 1 other location - About 1 hr to fix
modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js on lines 323..327

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.sizeFieldset = new OO.ui.FieldsetLayout( {
        $overlay: this.$overlay,
        label: ve.msg( 'visualeditor-dialog-media-size-section' ),
        help: ve.msg( 'visualeditor-dialog-media-size-section-help' )
    } );
Severity: Major
Found in modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js and 1 other location - About 1 hr to fix
modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js on lines 308..312

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function parseWikitextFragment has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.init.mw.Target.prototype.parseWikitextFragment = function ( wikitext, pst, doc ) {
    let abortable, aborted;
    const abortedPromise = ve.createDeferred().reject( 'http',
        { textStatus: 'abort', exception: 'abort' } ).promise();

Severity: Minor
Found in modules/ve-mw/init/targets/ve.init.mw.Target.js - About 1 hr to fix

    Function runTests has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function runTests( lang ) {
    
        const runLang = runScreenshotTest.bind( this, lang );
    
        test.describe( 'Screenshots: ' + lang, function () {
    Severity: Minor
    Found in build/screenshots.userGuide.js - About 1 hr to fix

      Function setup has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ve.ui.MWSettingsPage.prototype.setup = function ( fragment, config ) {
          this.fragment = fragment;
      
          // Table of Contents items
          const tableOfContentsField = this.tableOfContents.getField();
      Severity: Minor
      Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js - About 1 hr to fix

        Function getSummaries has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ve.ui.MWEditSummaryWidget.prototype.getSummaries = function () {
            const splitSummary = this.constructor.static.splitSummary.bind( this.constructor.static );
            if ( !this.getSummariesPromise ) {
                if ( mw.user.isAnon() ) {
                    this.getSummariesPromise = ve.createDeferred().resolve( [] ).promise();
        Severity: Minor
        Found in modules/ve-mw/ui/widgets/ve.ui.MWEditSummaryWidget.js - About 1 hr to fix

          Function VeUiMWTransclusionOutlineTemplateWidget has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          ve.ui.MWTransclusionOutlineTemplateWidget = function VeUiMWTransclusionOutlineTemplateWidget( template, replacesPlaceholder ) {
              const spec = template.getSpec();
          
              // Parent constructor
              ve.ui.MWTransclusionOutlineTemplateWidget.super.call( this, template, {

            Function getLookupCacheDataFromResponse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            ve.ui.MWCategoryInputWidget.prototype.getLookupCacheDataFromResponse = function ( data ) {
                const result = [],
                    linkCacheUpdate = {},
                    query = data.query || {};
            
            
            Severity: Minor
            Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js - About 1 hr to fix

              Function addPartWidget has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              ve.ui.MWTransclusionOutlineWidget.prototype.addPartWidget = function ( part, newPosition, removed ) {
                  const keys = Object.keys( this.partWidgets ),
                      onlyPart = keys.length === 1 && this.partWidgets[ keys[ 0 ] ];
                  if ( onlyPart instanceof ve.ui.MWTransclusionOutlineTemplateWidget ) {
                      // To recalculate the height of the sticky header when we enter multi-part mode
              Severity: Minor
              Found in modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineWidget.js - About 1 hr to fix

                Function wrapText has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                ve.dm.MWWikitextSurfaceFragment.prototype.wrapText = function ( before, after, placeholder, forceWrap ) {
                    placeholder = OO.ui.resolveMsg( placeholder );
                
                    function unwrap( fragment ) {
                        const text = fragment.getText();
                Severity: Minor
                Found in modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js - About 1 hr to fix

                  Function setupEditor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  ve.ui.MWAceEditorWidget.prototype.setupEditor = function () {
                      let basePath = mw.config.get( 'wgExtensionAssetsPath', '' );
                  
                      if ( basePath.slice( 0, 2 ) === '//' ) {
                          // ACE uses web workers, which have importScripts, which don't like relative links.
                  Severity: Minor
                  Found in modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js - About 1 hr to fix

                    Function onEditSectionLinkClick has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            onEditSectionLinkClick: function ( mode, e, section ) {
                                const link = $( e.target ).closest( 'a' )[ 0 ];
                                if ( !link || !link.href ) {
                                    // Not a real link, probably added by a gadget or another extension (T328094)
                                    return;
                    Severity: Minor
                    Found in modules/ve-mw/preinit/ve.init.mw.DesktopArticleTarget.init.js - About 1 hr to fix

                      Function filterRendering has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      ve.ce.MWTransclusionNode.static.filterRendering = function ( contentNodes ) {
                          if ( !contentNodes.length ) {
                              return [];
                          }
                      
                      
                      Severity: Minor
                      Found in modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js - About 1 hr to fix

                        Function VeCeMWBlockImageNode has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        ve.ce.MWBlockImageNode = function VeCeMWBlockImageNode() {
                            // Parent constructor
                            ve.ce.MWBlockImageNode.super.apply( this, arguments );
                        
                            const type = this.model.getAttribute( 'type' );
                        Severity: Minor
                        Found in modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js - About 1 hr to fix

                          Similar blocks of code found in 8 locations. Consider refactoring.
                          Open

                          ve.dm.MWParameterModel.prototype.isDeprecated = function () {
                              return this.template.getSpec().isParameterDeprecated( this.name );
                          };
                          Severity: Major
                          Found in modules/ve-mw/dm/models/ve.dm.MWParameterModel.js and 7 other locations - About 1 hr to fix
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 60..62
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 74..76
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 123..125
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 130..132
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 137..139
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 144..146
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 151..153

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 8 locations. Consider refactoring.
                          Open

                          ve.dm.MWParameterModel.prototype.getDefaultValue = function () {
                              return this.template.getSpec().getParameterDefaultValue( this.name );
                          };
                          Severity: Major
                          Found in modules/ve-mw/dm/models/ve.dm.MWParameterModel.js and 7 other locations - About 1 hr to fix
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 60..62
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 67..69
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 74..76
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 123..125
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 137..139
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 144..146
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 151..153

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 8 locations. Consider refactoring.
                          Open

                          ve.dm.MWParameterModel.prototype.getType = function () {
                              return this.template.getSpec().getParameterType( this.name );
                          };
                          Severity: Major
                          Found in modules/ve-mw/dm/models/ve.dm.MWParameterModel.js and 7 other locations - About 1 hr to fix
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 60..62
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 67..69
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 74..76
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 123..125
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 130..132
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 137..139
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 144..146

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 8 locations. Consider refactoring.
                          Open

                          ve.dm.MWParameterModel.prototype.getSuggestedValues = function () {
                              return this.template.getSpec().getParameterSuggestedValues( this.name );
                          };
                          Severity: Major
                          Found in modules/ve-mw/dm/models/ve.dm.MWParameterModel.js and 7 other locations - About 1 hr to fix
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 60..62
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 67..69
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 74..76
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 130..132
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 137..139
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 144..146
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 151..153

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 8 locations. Consider refactoring.
                          Open

                          ve.dm.MWParameterModel.prototype.isSuggested = function () {
                              return this.template.getSpec().isParameterSuggested( this.name );
                          };
                          Severity: Major
                          Found in modules/ve-mw/dm/models/ve.dm.MWParameterModel.js and 7 other locations - About 1 hr to fix
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 67..69
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 74..76
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 123..125
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 130..132
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 137..139
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 144..146
                          modules/ve-mw/dm/models/ve.dm.MWParameterModel.js on lines 151..153

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language