Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Hooks/ChangesListLinesHandler.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method onEnhancedChangesListModifyLineData has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $changesList,
        &$data,
        $block,
        $rc,
        &$classes = [],
Severity: Minor
Found in client/includes/Hooks/ChangesListLinesHandler.php - About 45 mins to fix

    Method onOldChangesListRecentChangesLine has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $changesList,
        &$s,
        $rc,
        &$classes = [],
        &$attribs = []
    Severity: Minor
    Found in client/includes/Hooks/ChangesListLinesHandler.php - About 35 mins to fix

      Method factory has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Language $contentLanguage,
        UserNameUtils $userNameUtils,
        EntityIdParser $entityIdParser,
        RepoLinker $repoLinker,
        SettingsArray $clientSettings
      Severity: Minor
      Found in client/includes/Hooks/ChangesListLinesHandler.php - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function onEnhancedChangesListModifyBlockLineData(
        $changesList,
        &$data,
        $rc
    ): void {
        Severity: Minor
        Found in client/includes/Hooks/ChangesListLinesHandler.php and 1 other location - About 40 mins to fix
        client/includes/Hooks/ChangesListLinesHandler.php on lines 150..175

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function onEnhancedChangesListModifyLineData(
        $changesList,
        &$data,
        $block,
        $rc,
        Severity: Minor
        Found in client/includes/Hooks/ChangesListLinesHandler.php and 1 other location - About 40 mins to fix
        client/includes/Hooks/ChangesListLinesHandler.php on lines 118..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status