Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/RecentChanges/SiteLinkCommentCreator.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function getSiteLinkMessage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function getSiteLinkMessage( $action, Diff $siteLinkDiff, Title $title = null ) {
        if ( $siteLinkDiff->isEmpty() ) {
            return null;
        }
Severity: Minor
Found in client/includes/RecentChanges/SiteLinkCommentCreator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getChangeParamsForDiffOp has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getChangeParamsForDiffOp( DiffOp $diffOp, $siteId, $messagePrefix ) {
        $params = [];

        if ( $diffOp instanceof DiffOpAdd ) {
            $params['message'] = $messagePrefix . 'add';
Severity: Minor
Found in client/includes/RecentChanges/SiteLinkCommentCreator.php - About 1 hr to fix

    Method getSiteLinkAddRemoveParams has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getSiteLinkAddRemoveParams( DiffOp $diffOp, $action, $siteId, Title $title = null ) {
        $params = [];

        if ( in_array( $action, [ 'remove', 'restore' ] ) ) {
            // Messages: wikibase-comment-remove, wikibase-comment-restore
    Severity: Minor
    Found in client/includes/RecentChanges/SiteLinkCommentCreator.php - About 1 hr to fix

      Function getSiteLinkAddRemoveParams has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getSiteLinkAddRemoveParams( DiffOp $diffOp, $action, $siteId, Title $title = null ) {
        $params = [];

        if ( in_array( $action, [ 'remove', 'restore' ] ) ) {
            // Messages: wikibase-comment-remove, wikibase-comment-restore
      Severity: Minor
      Found in client/includes/RecentChanges/SiteLinkCommentCreator.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function needsTargetSpecificSummary has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function needsTargetSpecificSummary( Diff $siteLinkDiff, Title $title ) {
        if ( $siteLinkDiff->isEmpty() ) {
            return false;
        }
      Severity: Minor
      Found in client/includes/RecentChanges/SiteLinkCommentCreator.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $title->getPrefixedText() === $diffOp->getOldValue() ||
            $title->getPrefixedText() === $diffOp->getNewValue();
      Severity: Major
      Found in client/includes/RecentChanges/SiteLinkCommentCreator.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status