Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Usage/Sql/EntityUsageTable.php

Summary

Maintainability
B
4 hrs
Test Coverage

File EntityUsageTable.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Client\Usage\Sql;
Severity: Minor
Found in client/includes/Usage/Sql/EntityUsageTable.php - About 2 hrs to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            EntityIdParser $idParser,
        ?IDatabase $writeConnection,
        int $batchSize = 100,
        ?string $tableName = null,
        int $addUsagesBatchSize = 500
    Severity: Minor
    Found in client/includes/Usage/Sql/EntityUsageTable.php - About 35 mins to fix

      Function getUsedEntityIdStrings has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getUsedEntityIdStrings( array $idStrings ): array {
        // Note: We need to use one (sub)query per entity here, per T116404
        $subQueries = $this->getUsedEntityIdStringsQueries( $idStrings );
        $readConnection = $this->db->connections()->getReadConnection();
      Severity: Minor
      Found in client/includes/Usage/Sql/EntityUsageTable.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status