Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/resources/jquery.wikibase/jquery.wikibase.siteselector.js

Summary

Maintainability
F
1 wk
Test Coverage

Function _create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        _create: function () {
            var self = this;

            $.ui.suggester.prototype._create.apply( this, arguments );
Severity: Minor
Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js - About 1 hr to fix

    Function _initMenu has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _initMenu: function ( ooMenu ) {
            var self = this;

            $.ui.suggester.prototype._initMenu.apply( this, arguments );
    Severity: Minor
    Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _create: function () {
            var self = this;

            $.ui.suggester.prototype._create.apply( this, arguments );
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 3 days to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 42..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 581.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _initMenu: function ( ooMenu ) {
            var self = this;

            $.ui.suggester.prototype._initMenu.apply( this, arguments );
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 2 days to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 135..169

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 364.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _getSuggestionsFromArray: function ( term, source ) {
            var self = this,
                deferred = $.Deferred();

            if ( term === '' ) {
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 1 day to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 211..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 220.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _selectFirstSite: function () {
            var menu = this.options.menu,
                menuItems = menu.option( 'items' ),
                site = null;
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 7 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 110..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 179.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _moveOffEdge: function ( direction ) {
            if ( direction === 'previous' ) {
                var menu = this.options.menu,
                    items = menu.option( 'items' );
                menu.activate( items[ items.length - 1 ] );
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 6 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 184..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _considerSuggestion: function ( site ) {
            var check = [
                site.getId(),
                site.getShortName(),
                site.getName(),
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 5 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 245..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 146.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _move: function ( direction, activeItem, allItems ) {
            $.ui.suggester.prototype._move.apply( this, arguments );
            if ( this._selectedSite === this.options.menu.getActiveItem().getSite() ) {
                this.element.val( this._term );
            }
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 3 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _grepSubDomainFromTerm: function () {
            // Extract either a subdomain (the word after "//") or simply the first word.
            var matches = /\/\/(\w[\w-]+)/.exec( this._term )
                || /(\w[\w-]+)/.exec( this._term );
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 2 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 266..272

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          var Item = function ( label, value, site ) {
            if ( !label || !value || !site ) {
                throw new Error( 'Required parameter(s) not specified' );
            }
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 2 hrs to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 344..352

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _getSuggestions: function ( term ) {
            var source = typeof this.options.source === 'function'
                ? this.options.source()
                : this.options.source;
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 1 hr to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 200..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              destroy: function () {
            $( this.options.menu ).off( 'siteselector' );
            $.ui.suggester.prototype.destroy.call( this );
        },
      Severity: Major
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 1 hr to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 102..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _createMenuItemFromSuggestion: function ( site, requestTerm ) {
            return new $.wikibase.siteselector.Item(
                this._createItemLabel( site, requestTerm ),
                this._createItemValue( site ),
                site
      Severity: Minor
      Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js and 1 other location - About 50 mins to fix
      view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 282..288

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status