Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Hooks/ShowSearchHitHandler.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method onShowSearchHit has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function onShowSearchHit( $searchPage, $result,
        $terms, &$link, &$redirect, &$section, &$extract, &$score, &$size, &$date, &$related,
        &$html
Severity: Major
Found in repo/includes/Hooks/ShowSearchHitHandler.php - About 1 hr to fix

    Method onShowSearchHit has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function onShowSearchHit( $searchPage, $result,
        $terms, &$link, &$redirect, &$section, &$extract, &$score, &$size, &$date, &$related,
        &$html
    ): void {
        if ( $result instanceof ExtendedResult ) {
    Severity: Minor
    Found in repo/includes/Hooks/ShowSearchHitHandler.php - About 1 hr to fix

      Function onShowSearchHit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function onShowSearchHit( $searchPage, $result,
        $terms, &$link, &$redirect, &$section, &$extract, &$score, &$size, &$date, &$related,
        &$html
    ): void {
        if ( $result instanceof ExtendedResult ) {
      Severity: Minor
      Found in repo/includes/Hooks/ShowSearchHitHandler.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method onShowSearchHitTitle has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              &$title,
        &$titleSnippet,
        $result,
        $terms,
        $specialSearch,
      Severity: Major
      Found in repo/includes/Hooks/ShowSearchHitHandler.php - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status