Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Interactors/ItemMergeInteractor.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method mergeItems has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function mergeItems(
        ItemId $fromId,
        ItemId $toId,
        IContextSource $context,
        array $ignoreConflicts = [],
Severity: Minor
Found in repo/includes/Interactors/ItemMergeInteractor.php - About 1 hr to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            MergeFactory $mergeFactory,
        EntityRevisionLookup $entityRevisionLookup,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityPermissionChecker $permissionChecker,
        SummaryFormatter $summaryFormatter,
    Severity: Major
    Found in repo/includes/Interactors/ItemMergeInteractor.php - About 1 hr to fix

      Method mergeItems has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ItemId $fromId,
        ItemId $toId,
        IContextSource $context,
        array $ignoreConflicts = [],
        ?string $summary = null,
      Severity: Major
      Found in repo/includes/Interactors/ItemMergeInteractor.php - About 50 mins to fix

        Method attemptSaveMerge has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Item $fromItem,
        Item $toItem,
        ?string $summary,
        IContextSource $context,
        bool $bot,
        Severity: Minor
        Found in repo/includes/Interactors/ItemMergeInteractor.php - About 45 mins to fix

          Method saveItem has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Item $item,
        FormatableSummary $summary,
        IContextSource $context,
        bool $bot,
        array $tags
          Severity: Minor
          Found in repo/includes/Interactors/ItemMergeInteractor.php - About 35 mins to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function __construct(
        MergeFactory $mergeFactory,
        EntityRevisionLookup $entityRevisionLookup,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityPermissionChecker $permissionChecker,
            Severity: Major
            Found in repo/includes/Interactors/ItemMergeInteractor.php and 4 other locations - About 2 hrs to fix
            repo/includes/ChangeOp/StatementChangeOpFactory.php on lines 59..77
            repo/includes/Interactors/EntityRedirectCreationInteractor.php on lines 45..63
            repo/rest-api/src/Application/UseCases/PatchStatement/PatchStatement.php on lines 34..52
            repo/rest-api/src/Infrastructure/DataAccess/EntityUpdater.php on lines 44..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status