Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/LinkedData/EntityDataSerializationService.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method rdfSerialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function rdfSerialize(
        EntityRevision $entityRevision,
        ?RedirectRevision $followedRedirect,
        array $incomingRedirects,
        RdfBuilder $rdfBuilder,
Severity: Minor
Found in repo/includes/LinkedData/EntityDataSerializationService.php - About 1 hr to fix

    Method getFlavor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getFlavor( ?string $flavorName ): int {
        switch ( $flavorName ) {
            case 'simple':
                return RdfProducer::PRODUCE_TRUTHY_STATEMENTS
                    | RdfProducer::PRODUCE_SITELINKS
    Severity: Minor
    Found in repo/includes/LinkedData/EntityDataSerializationService.php - About 1 hr to fix

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EntityTitleStoreLookup $entityTitleStoreLookup,
        PropertyDataTypeLookup $propertyLookup,
        EntityDataFormatProvider $entityDataFormatProvider,
        SerializerFactory $serializerFactory,
        Serializer $entitySerializer,
      Severity: Major
      Found in repo/includes/LinkedData/EntityDataSerializationService.php - About 1 hr to fix

        Method getSerializedData has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $format,
        EntityRevision $entityRevision,
        RedirectRevision $followedRedirect = null,
        array $incomingRedirects = [],
        ?string $flavor = null
        Severity: Minor
        Found in repo/includes/LinkedData/EntityDataSerializationService.php - About 35 mins to fix

          Method rdfSerialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  EntityRevision $entityRevision,
        ?RedirectRevision $followedRedirect,
        array $incomingRedirects,
        RdfBuilder $rdfBuilder,
        ?string $flavor = null
          Severity: Minor
          Found in repo/includes/LinkedData/EntityDataSerializationService.php - About 35 mins to fix

            Function rdfSerialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function rdfSerialize(
        EntityRevision $entityRevision,
        ?RedirectRevision $followedRedirect,
        array $incomingRedirects,
        RdfBuilder $rdfBuilder,
            Severity: Minor
            Found in repo/includes/LinkedData/EntityDataSerializationService.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status