Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Specials/SpecialListProperties.php

Summary

Maintainability
A
4 hrs
Test Coverage

Method formatRow has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function formatRow( EntityId $propertyId ) {
        $title = $this->titleLookup->getTitleForId( $propertyId );
        $language = $this->getLanguage();

        if ( !$title->exists() ) {
Severity: Minor
Found in repo/includes/Specials/SpecialListProperties.php - About 1 hr to fix

    Method showForm has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function showForm() {
        $dataTypeSelect = new DataTypeSelector(
            $this->dataTypeFactory->getTypes(),
            $this->getLanguage()->getCode()
        );
    Severity: Minor
    Found in repo/includes/Specials/SpecialListProperties.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              DataTypeFactory $dataTypeFactory,
        PropertyInfoLookup $propertyInfoLookup,
        FallbackLabelDescriptionLookupFactory $labelDescriptionLookupFactory,
        EntityIdFormatterFactory $entityIdFormatterFactory,
        EntityTitleLookup $titleLookup
      Severity: Minor
      Found in repo/includes/Specials/SpecialListProperties.php - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            public function __construct(
        DataTypeFactory $dataTypeFactory,
        PropertyInfoLookup $propertyInfoLookup,
        FallbackLabelDescriptionLookupFactory $labelDescriptionLookupFactory,
        EntityIdFormatterFactory $entityIdFormatterFactory,
        Severity: Major
        Found in repo/includes/Specials/SpecialListProperties.php and 2 other locations - About 40 mins to fix
        repo/includes/Specials/SpecialGoToLinkedPage.php on lines 64..78
        repo/includes/Specials/SpecialRedirectEntity.php on lines 33..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status