wikimedia/mediawiki-ruby-api

View on GitHub

Showing 3 of 3 total issues

Class Client has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client
    FORMAT = 'json'

    attr_reader :cookies
    attr_accessor :logged_in
Severity: Minor
Found in lib/mediawiki_api/client.rb - About 2 hrs to fix

    Method upload_image has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def upload_image(filename, path, comment, ignorewarnings, text = nil)
    Severity: Minor
    Found in lib/mediawiki_api/client.rb - About 35 mins to fix

      Method log_in has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def log_in(username, password, token = nil)
            params = { lgname: username, lgpassword: password, token_type: false }
            params[:lgtoken] = token unless token.nil?
      
            data = action(:login, params).data
      Severity: Minor
      Found in lib/mediawiki_api/client.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language