Sign upLogin

wooyek/django-opt-out

View on GitHub
Star

Showing 7 of 15 total issues

Function _send_robust has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def _send_robust(message):
    try:
        return message.send()
    except SparkPostAPIException as ex:  # pragma: no cover
        if ex.status == 1902 or not settings.FAIL_ON_EMAIL_SUPPRESSION:
Severity: Minor
Found in src/django_opt_out/plugins/sparkpost/__init__.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send_email has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def send_email(subject, to, ctx, template_html, template_txt=None, **kwargs):
Severity: Minor
Found in src/django_opt_out/plugins/sparkpost/__init__.py - About 45 mins to fix

    Function save has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def save(self, force_insert=False, force_update=False, using=None, update_fields=None):
    Severity: Minor
    Found in src/django_opt_out/models.py - About 35 mins to fix

      Function suppress_email has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def suppress_email(sender, view, request, opt_out, **kwargs):
      Severity: Minor
      Found in src/django_opt_out/plugins/sparkpost/hooks.py - About 35 mins to fix

        Function create_opt_out has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def create_opt_out(sender, request, email, data, **kwargs):
        Severity: Minor
        Found in src/django_opt_out/plugins/sparkpost/hooks.py - About 35 mins to fix

          Function remove_suppression has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def remove_suppression(sender, view, request, opt_out, **kwargs):
          Severity: Minor
          Found in src/django_opt_out/plugins/sparkpost/hooks.py - About 35 mins to fix

            Function handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def handle(self, *args, **options):
        if not options['force']:
            try:
                assert models.OptOutTag.objects.count() == 0
                assert models.OptOutFeedback.objects.count() == 0
            Severity: Minor
            Found in src/django_opt_out/management/commands/opt_out_feedback_defaults.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language