workcraft/workcraft

View on GitHub

Showing 2,488 of 2,488 total issues

Avoid too many return statements within this method.
Open

            return new Result<>(e);

    Avoid too many return statements within this method.
    Open

                                return false;

      Avoid too many return statements within this method.
      Open

                      return Result.failure(new SpotChainOutput(ltl2tgbaResult, mpsatResult));

        Identical blocks of code found in 11 locations. Consider refactoring.
        Open

            private final JLabel label = new JLabel() {
                @Override
                public void paint(final Graphics g) {
                    g.setColor(getBackground());
                    g.fillRect(0, 0, getWidth(), getHeight());
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CycleAnalyserTool.java on lines 457..464
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 440..447
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 536..543
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/CycleAnalyserTool.java on lines 349..356
        workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/EncodingConflictAnalyserTool.java on lines 242..249
        workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/StgSimulationTool.java on lines 217..224
        workcraft/WorkcraftCore/src/org/workcraft/gui/controls/FlatHeaderRenderer.java on lines 14..21
        workcraft/WorkcraftCore/src/org/workcraft/gui/lists/ColorListCellRenderer.java on lines 14..21
        workcraft/WorkcraftCore/src/org/workcraft/gui/properties/PropertyDeclarationRenderer.java on lines 13..20
        workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java on lines 549..556

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 11 locations. Consider refactoring.
        Open

                private final JLabel label = new JLabel() {
                    @Override
                    public void paint(Graphics g) {
                        g.setColor(getBackground());
                        g.fillRect(0, 0, getWidth(), getHeight());
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CycleAnalyserTool.java on lines 457..464
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 536..543
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/CycleAnalyserTool.java on lines 349..356
        workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/EncodingConflictAnalyserTool.java on lines 242..249
        workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/StgSimulationTool.java on lines 217..224
        workcraft/WorkcraftCore/src/org/workcraft/gui/controls/FlatHeaderRenderer.java on lines 14..21
        workcraft/WorkcraftCore/src/org/workcraft/gui/lists/ColorListCellRenderer.java on lines 14..21
        workcraft/WorkcraftCore/src/org/workcraft/gui/properties/PropertyDeclarationRenderer.java on lines 13..20
        workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ColorTableCellRenderer.java on lines 11..18
        workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java on lines 549..556

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this method.
        Open

                            return Result.exception(e);

          Avoid too many return statements within this method.
          Open

                      return Result.success(new VerificationChainOutput(
                              devExportResult, pcompResult, mpsatResult, completionParameters, message));

            Identical blocks of code found in 11 locations. Consider refactoring.
            Open

                private final JLabel label = new FlatLabel() {
                    @Override
                    public void paint(Graphics g) {
                        g.setColor(getBackground());
                        g.fillRect(0, 0, getWidth(), getHeight());
            workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CycleAnalyserTool.java on lines 457..464
            workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 440..447
            workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 536..543
            workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/CycleAnalyserTool.java on lines 349..356
            workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/EncodingConflictAnalyserTool.java on lines 242..249
            workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/StgSimulationTool.java on lines 217..224
            workcraft/WorkcraftCore/src/org/workcraft/gui/controls/FlatHeaderRenderer.java on lines 14..21
            workcraft/WorkcraftCore/src/org/workcraft/gui/properties/PropertyDeclarationRenderer.java on lines 13..20
            workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ColorTableCellRenderer.java on lines 11..18
            workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java on lines 549..556

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this method.
            Open

                        return 0.0;

              Avoid too many return statements within this method.
              Open

                      return null;

                Avoid too many return statements within this method.
                Open

                        return null;

                  Avoid too many return statements within this method.
                  Open

                                          return Result.failure(new VerificationChainOutput(
                                                  devExportResult, pcompResult, deadlockMpsatResult, deadlockParameters));

                    Avoid too many return statements within this method.
                    Open

                                return Result.success(new CombinedChainOutput(
                                        devExportResult, pcompResult, unfoldingResult, mpsatResultList, verificationParametersList));

                      Avoid too many return statements within this method.
                      Open

                                  return;

                        Avoid too many return statements within this method.
                        Open

                                        return Result.success(new VerificationChainOutput(
                                                exportResult, null, mpsatResult, verificationParameters,
                                                "Dataflow has a deadlock"));

                          Avoid too many return statements within this method.
                          Open

                                          return;

                            Avoid too many return statements within this method.
                            Open

                                        return new Result<>(e);

                              Avoid too many return statements within this method.
                              Open

                                          return Result.success(new VerificationChainOutput(
                                                  exportResult, null, mpsatResult, verificationParameters,
                                                  "Dataflow is output-persistent"));

                                Identical blocks of code found in 11 locations. Consider refactoring.
                                Open

                                    private final JLabel label = new FlatLabel() {
                                        @Override
                                        public void paint(Graphics g) {
                                            g.setColor(getBackground());
                                            g.fillRect(0, 0, getWidth(), getHeight());
                                workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CycleAnalyserTool.java on lines 457..464
                                workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 440..447
                                workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 536..543
                                workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/CycleAnalyserTool.java on lines 349..356
                                workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/EncodingConflictAnalyserTool.java on lines 242..249
                                workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/StgSimulationTool.java on lines 217..224
                                workcraft/WorkcraftCore/src/org/workcraft/gui/controls/FlatHeaderRenderer.java on lines 14..21
                                workcraft/WorkcraftCore/src/org/workcraft/gui/lists/ColorListCellRenderer.java on lines 14..21
                                workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ColorTableCellRenderer.java on lines 11..18
                                workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java on lines 549..556

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 40.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Avoid too many return statements within this method.
                                Open

                                                return;
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language