workcraft/workcraft

View on GitHub

Showing 2,484 of 2,484 total issues

Identical blocks of code found in 5 locations. Consider refactoring.
Open

            if (!mpsatResult.isSuccess()) {
                if (mpsatResult.isCancel()) {
                    return Result.cancel();
                }
                return Result.failure(new VerificationChainOutput(
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 128..134
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 69..75
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 83..89
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 103..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

            return 0.0;

    Avoid too many return statements within this method.
    Open

            return null;

      Avoid too many return statements within this method.
      Open

                          return Result.success(new VerificationChainOutput(
                                  compositionExportResult, modPcompResult, conformationMpsatResult, conformationParameters,
                                  "Circuit does not conform to the environment after the following trace(s):"));

        Avoid too many return statements within this method.
        Open

                                    return Result.cancel();

          Avoid too many return statements within this method.
          Open

                      return Result.success(new VerificationChainOutput(
                              envExportResult, null, mpsatResult, verificationParameters,
                              "The circuit strictly implements its environment."));

            Avoid too many return statements within this method.
            Open

                                return Result.failure(new VerificationChainOutput(
                                        devExportResult, pcompResult, null, preparationParameters));

              Avoid too many return statements within this method.
              Open

                              return Result.success(new VerificationChainOutput(
                                      exportResult, null, mpsatResult, verificationParameters, "Policy net has a deadlock"));

                Avoid too many return statements within this method.
                Open

                                return Result.failure(new VerificationChainOutput(
                                        exportResult, null, persistencyResult, persistencyParameters));
                Severity: Major
                Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

                  Identical blocks of code found in 11 locations. Consider refactoring.
                  Open

                      private final JLabel label = new JLabel() {
                          @Override
                          public void paint(Graphics g) {
                              g.setColor(getBackground());
                              g.fillRect(0, 0, getWidth(), getHeight());
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CycleAnalyserTool.java on lines 457..464
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 440..447
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 536..543
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/CycleAnalyserTool.java on lines 349..356
                  workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/EncodingConflictAnalyserTool.java on lines 242..249
                  workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/StgSimulationTool.java on lines 217..224
                  workcraft/WorkcraftCore/src/org/workcraft/gui/lists/ColorListCellRenderer.java on lines 14..21
                  workcraft/WorkcraftCore/src/org/workcraft/gui/properties/PropertyDeclarationRenderer.java on lines 13..20
                  workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ColorTableCellRenderer.java on lines 11..18
                  workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java on lines 549..556

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 6 locations. Consider refactoring.
                  Open

                                      if (!deadlockMpsatResult.isSuccess()) {
                                          if (deadlockMpsatResult.isCancel()) {
                                              return Result.cancel();
                                          }
                                          return Result.failure(new VerificationChainOutput(
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 109..115
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 175..181
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 224..230
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 270..276
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java on lines 140..145

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Avoid too many return statements within this method.
                  Open

                          return true;

                    Avoid too many return statements within this method.
                    Open

                                return ((VisualCircuitComponent) visualNode).getReferencedComponent();

                      Avoid too many return statements within this method.
                      Open

                              return "!" + expression;

                        Avoid too many return statements within this method.
                        Open

                                                return Result.cancel();

                          Avoid too many return statements within this method.
                          Open

                                      return new Result<>(e);

                            Avoid too many return statements within this method.
                            Open

                                        return new Result<>(e);

                              Avoid too many return statements within this method.
                              Open

                                              return Result.success(new VerificationChainOutput(
                                                      exportResult, null, mpsatResult, verificationParameters,
                                                      "Dataflow has a deadlock"));

                                Avoid too many return statements within this method.
                                Open

                                                return;

                                  Avoid too many return statements within this method.
                                  Open

                                                          return Result.cancel();
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language