workcraft/workcraft

Avoid deeply nested control flow statements.

Open

                        for (MathNode node : wtg.getPostset(entry)) {
                            if ((isFirstTransition(wtg, node)) && (isWaveformInChoice(wtg, waveform))) {
                                DialogUtils.showError("Signal '" + wtg.getName(entry.getSignal())
                                        + "' cannot be fired immediately after a choice, in waveform '"
                                        + wtg.getName(waveform) + "'.");

Avoid deeply nested control flow statements.

Open

                        if (node instanceof TransitionEvent) {
                            TransitionEvent dstTransition = (TransitionEvent) node;
                            if (dstTransition.getSignal().getType() == Signal.Type.INPUT) {
                                String msg = "Internal signal '" + wtg.getName(transition.getSignal())
                                        + "' triggers input signal '"

Avoid deeply nested control flow statements.

Open

                        if (node instanceof TransitionEvent) {
                            TransitionEvent dstTransition = (TransitionEvent) node;
                            Signal signal = dstTransition.getSignal();
                            if (signal.getType() != Signal.Type.INPUT) {
                                String transitionName = wtg.getName(transition.getSignal()) + direction.getSymbol();

Method processTransition has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private static void processTransition(Wtg wtg, TransitionEvent visitingTransition, Set<TransitionEvent> outputHasFired,
                                          Set<String> firedBeforeOut, Integer index,
                                          Map<TransitionEvent, Map<Signal, Pair<Boolean, Integer>>> inputsFiredAfterOutput) {

Avoid deeply nested control flow statements.

Open

                        if (previousState != Signal.State.STABLE) {
                            DialogUtils.showError("Signal '" + signalGuarded
                                    + "' should be stable before reaching the state '"
                                    + wtg.getName(precedingState) + "'.");
                            return false;

Avoid deeply nested control flow statements.

Open

                                if ((finalWaveformSignalState.containsKey(signal.getKey())) &&
                                        (!finalWaveformSignalState.get(signal.getKey()).equals(signal.getValue()))) {
                                    msg += ' ' + signal.getKey();
                                }

Avoid deeply nested control flow statements.

Open

                        for (Signal signal : guardedSignals)  {
                            inputsFiredAfterOutput.get(transition).put(signal, new Pair<>(true, 0));
                        }

Method checkTransitionConnections has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private static boolean checkTransitionConnections(Wtg wtg, Waveform waveform, Set<? extends MathNode> connections,
            Signal signal, String connectionType) {

Method signalFollowsSynthesisGuidelines has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private static boolean signalFollowsSynthesisGuidelines(Wtg wtg, String signal, Map<Waveform, Set<String>> firedBeforeOut,
                                                            Map<Waveform, Set<String>> firedAfterOut, Map<Waveform, Boolean> hasOutput) {

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

        return true;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

        return true;

Avoid too many return statements within this method.

Open

        return true;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

        return true;

Avoid too many return statements within this method.

Open

        return true;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public static boolean checkExitEventPresetPostset(Wtg wtg) {
        for (Waveform waveform : wtg.getWaveforms()) {
            for (ExitEvent exit : wtg.getExits(waveform)) {
                String msg = "Waveform '" + wtg.getName(waveform) + "' has an exit event ";
                if (!wtg.getPostset(exit).isEmpty()) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public static boolean checkEntryEventPresetPostset(Wtg wtg) {
        for (Waveform waveform : wtg.getWaveforms()) {
            for (EntryEvent entry : wtg.getEntries(waveform)) {
                String msg = "Waveform '" + wtg.getName(waveform) + "' has an entry event ";
                if (!wtg.getPreset(entry).isEmpty()) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public static boolean checkWaveformsHaveEntryState(Wtg wtg) {
        for (Waveform waveform : wtg.getWaveforms()) {
            Set<MathNode> preset = wtg.getPreset(waveform);
            String name = wtg.getName(waveform);
            if (preset.isEmpty()) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public static boolean checkWaveformsHaveExitState(Wtg wtg) {
        for (Waveform waveform : wtg.getWaveforms()) {
            Set<MathNode> postset = wtg.getPostset(waveform);
            String name = wtg.getName(waveform);
            if (postset.isEmpty()) {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

            for (MathNode n : wtg.getPostset(node)) {
                if (!reachableNodes.contains(n)) {
                    reachableNodes.add(n);
                    nodesToVisit.add(n);
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for (String signalName : getUnstableSignalNames(wtg)) {
            unstableSignalPlaces.add(getLowStateName(signalName));
            unstableSignalPlaces.add(getHighStateName(signalName));
            unstableSignalPlaces.add(getStableStateName(signalName));
            unstableSignalPlaces.add(getUnstableStateName(signalName));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (wtg.getExits(waveform).size() > exitEventSignals.size()) {
                DialogUtils.showError("Waveform '" + wtg.getName(waveform) + "' has repeated exit events.");
                return false;
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (wtg.getEntries(waveform).size() > entryEventSignals.size()) {
                DialogUtils.showError("Waveform '" + wtg.getName(waveform) + "' has repeated entry events.");
                return false;
            }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

            } else if (direction == TransitionEvent.Direction.FALL) {
                if ((previousState != Signal.State.HIGH) && (previousState != Signal.State.UNSTABLE)) {
                    consistent = false;
                }
            }  else if (direction == TransitionEvent.Direction.STABILISE) {

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

            } else if (direction == TransitionEvent.Direction.DESTABILISE) {
                if ((previousState != Signal.State.HIGH) && (previousState != Signal.State.LOW)) {
                    consistent = false;
                }
            }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

            if (direction == TransitionEvent.Direction.RISE) {
                if ((previousState != Signal.State.LOW) && (previousState != Signal.State.UNSTABLE)) {
                    consistent = false;
                }
            } else if (direction == TransitionEvent.Direction.FALL) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                            if ((isFirstTransition(wtg, node)) && (isWaveformInChoice(wtg, waveform))) {
                                DialogUtils.showError("Signal '" + wtg.getName(entry.getSignal())
                                        + "' cannot be fired immediately after a choice, in waveform '"
                                        + wtg.getName(waveform) + "'.");
                                return false;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                                        isFirstTransitionInputInSuccessorWaveforms(wtg, waveform)) {
                                    DialogUtils.showError("Internal signal '" + wtg.getName(transition.getSignal())
                                            + "' triggers an input signal with its transition at the end of waveform '"
                                            + wtg.getName(waveform) + "'.");
                                    return false;

• Read up
  Read up