xoopscube/altsys

View on GitHub
xoops_trust_path/libs/altsys/class/d3utilities.php

Summary

Maintainability
C
1 day
Test Coverage

Function update has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public function update()
    {
        $db =& XoopsDatabaseFactory::getDatabaseConnection();

        // search appropriate column for getting primary_key
Severity: Minor
Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_view_edit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function get_view_edit()
    {
        $id = $this->init_default_values();

        $lines = [];
Severity: Minor
Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_view_edit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_view_edit()
    {
        $id = $this->init_default_values();

        $lines = [];
Severity: Minor
Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

    Method update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function update()
        {
            $db =& XoopsDatabaseFactory::getDatabaseConnection();
    
            // search appropriate column for getting primary_key
    Severity: Minor
    Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

      Function insert has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function insert()
          {
              $db =& XoopsDatabaseFactory::getDatabaseConnection();
      
              $id = $this->init_default_values();
      Severity: Minor
      Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function init_default_values has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function init_default_values(): int
          {
              $db =& XoopsDatabaseFactory::getDatabaseConnection();
      
              if (@$_GET['id']) {
      Severity: Minor
      Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function delete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function delete($delete_comments = false, $delete_notifications = false)
          {
              $db =& XoopsDatabaseFactory::getDatabaseConnection();
      
              $ret = [];
      Severity: Minor
      Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct($mydirname, $table_body, $primary_key, $cols, $page_name, $action_base_hiddens)
      Severity: Minor
      Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status